Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update for symfony 3.4+ #372

Closed
cordoval opened this issue Nov 14, 2017 · 5 comments
Closed

update for symfony 3.4+ #372

cordoval opened this issue Nov 14, 2017 · 5 comments

Comments

@cordoval
Copy link

User Deprecated: Implementing "Symfony\Component\HttpKernel\DataCollector\DataCollectorInterface" without the "reset()" method is deprecated since version 3.4 and will be unsupported in 4.0 for class "Snc\RedisBundle\DataCollector\RedisDataCollector".
@xabbuh
Copy link
Contributor

xabbuh commented Nov 14, 2017

could probably be done as part of #370

@SiM07
Copy link
Contributor

SiM07 commented Nov 14, 2017

It's already fix in master. #366

@cordoval
Copy link
Author

thanks @SiM07 you rock, do you mind giving us a tag? ✈️ taking off

@xabbuh
Copy link
Contributor

xabbuh commented Nov 14, 2017

Oh I should have remembered 🙈

@cordoval
Copy link
Author

great work @xabbuh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@SiM07 @cordoval @xabbuh