Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos and improve language #285

Merged
merged 2 commits into from
Aug 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/finch/http1/pool_metrics.ex
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ defmodule Finch.HTTP1.PoolMetrics do

* `:pool_index` - Index of the pool
* `:pool_size` - Total number of connections of the pool
* `:available_connections` - Number of avaialable connections
* `:available_connections` - Number of available connections
* `:in_use_connections` - Number of connections currently in use

Caveats:
Expand Down
2 changes: 1 addition & 1 deletion lib/finch/http2/pool.ex
Original file line number Diff line number Diff line change
Expand Up @@ -450,7 +450,7 @@ defmodule Finch.HTTP2.Pool do
{:keep_state, data}
end

# If we're in a read only state than respond with an error immediately
# If we're in a read only state then respond with an error immediately
def connected_read_only({:call, from}, {:request, _, _, _}, _) do
{:keep_state_and_data, {:reply, from, {:error, Error.exception(:read_only)}}}
end
Expand Down
2 changes: 1 addition & 1 deletion lib/finch/pool_manager.ex
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ defmodule Finch.PoolManager do

defp maybe_drop_tls_options(config, _), do: config

# Hostname is required when the address is not a url (binary) so we need to specify
# Hostname is required when the address is not a URL (binary) so we need to specify
# a default value in case the configuration does not specify one.
defp maybe_add_hostname(config, {_scheme, {:local, _path}, _port} = _shp) when is_map(config) do
conn_opts =
Expand Down
2 changes: 1 addition & 1 deletion test/support/finch_case.ex
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,6 @@ defmodule FinchCase do
{:ok, bypass ++ [finch_name: context.test]}
end

@doc "Returns the url for a Bypass instance"
@doc "Returns the URL for a Bypass instance"
def endpoint(%{port: port}, path \\ "/"), do: "http://localhost:#{port}#{path}"
end
Loading