Crackly audio in or near boss rooms

[dagit]

In the long room before kraid (with the three pirates and minikraid), the audio crackles. I noticed the same issue in croc's room. I'm on linux if that matters.

[arrowgent]

same issue (linux x86_64)
changing frequency to 48000 and buffer up to 2048 did not fix this

# DSP frequency in samples per second (e.g. 48000, 44100, 32000, 22050, 11025)
AudioFreq = 48000

# Audio buffer size in samples (power of 2; e.g., 4096, 2048, 1024) [try 1024 if sound is crackly]. The higher the more lag before you hear sounds.
AudioSamples = 2048

i should note, its only the music that begins to crackle
i did not notice audio sfx having any issues.

im also playing on a 3.0GHZ intel i-7. not a low power device like a raspberry pi

[PanMartinS]

I've also had this problem, and I figured out that it has to do with a pointer out of array bounds bug at https://github.com/snesrev/sm/blob/main/src/spc_player.c#L643. The value of "p->ram[c->pattern_order_ptr_for_chan]" few lines above can only be 0 to 3 else we have the pointer "ep" goes out of bounds of the array "kEchoFirParameters". But in the room before kraid, this value is 80. I'm not familiar with the code so I don't know what the correct code should be. But changing the code here removes the sound glitch.