Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue after session timeout #1315

Closed
tomaszdubiel18 opened this issue Nov 6, 2023 · 11 comments
Closed

Issue after session timeout #1315

tomaszdubiel18 opened this issue Nov 6, 2023 · 11 comments

Comments

@tomaszdubiel18
Copy link

Describe the bug
I have Thruk opened in multiple tabs of a browser

Thruk Version
3.08.3

To Reproduce
Log in.
After session (cookie) time out, after getting to the main webpage (before log in) in the address it is added:
thruk/cgi-bin/login.cgi?nocookie&thruk/#main.html
Try to log in. Then I want to refresh the other Thruk tabs (with some services view for example). Then the session is reset and I need to log in again. ONLY if I enter the main Thruk webpage, Thruk recognizes the session, but when I refresh URL of some exact part of the Thruk, then session gets reset. I need to re sign in in every tab or I need to get to them from main Thruk webpage.

Expected behavior
I log in once and I don't need to log in anymore.

Desktop (please complete the following information):

  • Firefox 119.0
@sni
Copy link
Owner

sni commented Nov 6, 2023

what was the URL before the session timeout?

@tomaszdubiel18
Copy link
Author

I think this doesn't matter, because it is the issue for all tabs and I have multiple different URLs, but for example:
thruk/cgi-bin/minemap.cgi
thruk/cgi-bin/status.cgi?host=<some_host>&style=detail&complex=&dfl_columns=host_name%2Cdescription%2Cstate%2Cplugin_output%2Clast_check

@tomaszdubiel18
Copy link
Author

Any new info? This bug is annoying.

@sni
Copy link
Owner

sni commented Aug 1, 2024

I cannot reproduce this. Could you upgrade to the lastest release and make sure you have the latest apache configuration for thruk. Sometimes the apache config does not get updated correctly and is available a .rpmnew or dpkg-new file.

@tomaszdubiel18
Copy link
Author

This is very easily reproducible:
thruk/cgi-bin/login.cgi?nocookie&thruk/#main.html
after successful login:
thruk/cgi-bin/main.cgi
I open any window in new tab, for example mine map:
thruk/cgi-bin/minemap.cgi
in first tab I logout and after logout:
thruk/cgi-bin/login.cgi
I refresh second tab and address becomes:
thruk/cgi-bin/login.cgi?nocookie&thruk/cgi-bin/minemap.cgi
in first tab I log in again:
address of first tab becomes:
thruk/cgi-bin/main.cgi
I refresh second tab. I still am on login page and this refresh caused logout in first tab

@tomaszdubiel18
Copy link
Author

We have the latest Thruk, v3.16.

@sni
Copy link
Owner

sni commented Aug 2, 2024

i see, that's expected behaviour. Whenever you open the login page, all existing cookies will be removed.
But i guess this could be changed in the future.

@tomaszdubiel18
Copy link
Author

It needs to be corrected. You see - I have a set of multiple Thruk tabs. I work one day, at the end of the day I leave it and come back again the next day. This way I have to login in every tab.
That's not normal.

@tomaszdubiel18
Copy link
Author

tomaszdubiel18 commented Aug 2, 2024

I don't refresh those tabs on my own. They refresh themselves, they catch expired session and either I have to manually open those addresses from the main page or I have to relogin in every tab.

@sni
Copy link
Owner

sni commented Aug 2, 2024

i agree, this should be changed.

@sni sni closed this as completed in 5e59e27 Aug 5, 2024
@sni
Copy link
Owner

sni commented Aug 5, 2024

should be fine with the next release, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants