Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suspicious static_assert condition in get_format_code() #66

Closed
tocic opened this issue Feb 1, 2023 · 1 comment · Fixed by #69
Closed

Suspicious static_assert condition in get_format_code() #66

tocic opened this issue Feb 1, 2023 · 1 comment · Fixed by #69
Labels
bug:confirmed Something isn't working (confirmed)
Milestone
v1.1

Comments

@tocic
Copy link
Member

tocic commented Feb 1, 2023 •
edited
Loading

https://github.com/cschreib/snitch/blob/eaa322ce9e7bbfbd0b39aa529ea59de4acbd9c42/src/snitch.cpp#L61-L64

I think static_assert(not std::is_same_v<T, T>, "unsupported type"); was implied. Now it leads to UB.
@cschreib cschreib added the bug:unconfirmed Something isn't working (to be confirmed) label Feb 2, 2023
@cschreib cschreib added this to the v1.x milestone Feb 2, 2023
@cschreib
Copy link
Member

cschreib commented Feb 2, 2023

Good catch!

@cschreib cschreib mentioned this issue Feb 2, 2023
Merged
@cschreib cschreib added bug:confirmed Something isn't working (confirmed) and removed bug:unconfirmed Something isn't working (to be confirmed) labels May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug:confirmed Something isn't working (confirmed)
Projects
None yet
Milestone
v1.1
Development

Successfully merging a pull request may close this issue.

Fix several bugs related to macro expansions snitch-org/snitch
2 participants
@cschreib @tocic