From 2f5e5bb30b1526f58dec9325f9316e45f32d4361 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?St=C3=A9phane=20Raimbault?= Date: Wed, 31 Aug 2022 16:28:02 +0200 Subject: [PATCH 1/2] Disambiguate debug messages of auth backends --- django_auth_adfs/backend.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/django_auth_adfs/backend.py b/django_auth_adfs/backend.py index 3f7c660..002aacf 100644 --- a/django_auth_adfs/backend.py +++ b/django_auth_adfs/backend.py @@ -414,7 +414,7 @@ def authenticate(self, request=None, access_token=None, **kwargs): # If there's no token or code, we pass control to the next authentication backend if access_token is None or access_token == '': - logger.debug("django_auth_adfs authentication backend was called but no authorization code was received") + logger.debug("django_auth_adfs authentication backend was called but no access token was received") return access_token = access_token.decode() From 8b8b3f071e6bd4fbbfd8d73ff2a9387cf8b4422b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?St=C3=A9phane=20Raimbault?= Date: Fri, 2 Sep 2022 17:13:08 +0200 Subject: [PATCH 2/2] Don't prefix log messages with django_auth_adfs --- django_auth_adfs/backend.py | 4 ++-- django_auth_adfs/config.py | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/django_auth_adfs/backend.py b/django_auth_adfs/backend.py index 002aacf..f556d85 100644 --- a/django_auth_adfs/backend.py +++ b/django_auth_adfs/backend.py @@ -390,7 +390,7 @@ class AdfsAuthCodeBackend(AdfsBaseBackend): def authenticate(self, request=None, authorization_code=None, **kwargs): # If there's no token or code, we pass control to the next authentication backend if authorization_code is None or authorization_code == '': - logger.debug("django_auth_adfs authentication backend was called but no authorization code was received") + logger.debug("Authentication backend was called but no authorization code was received") return # If loaded data is too old, reload it again @@ -414,7 +414,7 @@ def authenticate(self, request=None, access_token=None, **kwargs): # If there's no token or code, we pass control to the next authentication backend if access_token is None or access_token == '': - logger.debug("django_auth_adfs authentication backend was called but no access token was received") + logger.debug("Authentication backend was called but no access token was received") return access_token = access_token.decode() diff --git a/django_auth_adfs/config.py b/django_auth_adfs/config.py index ed9fdbd..12c36dc 100644 --- a/django_auth_adfs/config.py +++ b/django_auth_adfs/config.py @@ -204,7 +204,7 @@ def load_config(self): # If loaded data is too old, reload it again refresh_time = datetime.now() - timedelta(hours=settings.CONFIG_RELOAD_INTERVAL) if self._config_timestamp is None or self._config_timestamp < refresh_time: - logger.debug("Loading django_auth_adfs ID Provider configuration.") + logger.debug("Loading ID Provider configuration.") try: loaded = self._load_openid_config() self._mode = "openid_connect" @@ -224,7 +224,7 @@ def load_config(self): logger.warning("Could not load any data from ADFS server. Keeping previous configurations") self._config_timestamp = datetime.now() - logger.info("django_auth_adfs loaded settings from ADFS server.") + logger.info("Loaded settings from ADFS server.") logger.info("operating mode: %s", self._mode) logger.info("authorization endpoint: %s", self.authorization_endpoint) logger.info("token endpoint: %s", self.token_endpoint)