GarageDoorOpenerAdvanced.js

[c-o-m-m-a-n-d-e-r]

Hey,
in the GarageDoorOpenerAdvanced.js File in Line 464 ... i think it must be

if (field === "KNXDoorClose") {

or not ?

[giase82]

Hi,

I don't think so... The field in the example below is:
{ "Type": "KNXDoorClosed", "Listen": "2/3/2", "DPT": "DPT1" },

Do I missunderstand your question?

//Christof

[giase82]

However, I agree this is inconsistent with KNXDoorOpen. One could fix it the one or the other way around.

[c-o-m-m-a-n-d-e-r]

I know this was in the Example ... but i was debugging the process an the Type "KNXDoorClosed" was never get called.

After changing the Type to "KNXDoorClose" without the "d" and changing Line 464 everything was working fine.

[giase82]

Sorry for that. Fixed it. Struggling with the git-magic right now for creating branches, commit etc

[snowdd1]

Hi @giase82 , I think @c-o-m-m-a-n-d-e-r Paul already fixed that in PR #158
Right?

[giase82]

Yes! Sorry I did forget ;)

[snowdd1]

closed with #158