Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-911181: Add parameter to disable query context cache #912

Merged
merged 1 commit into from
Sep 11, 2023
Merged

SNOW-911181: Add parameter to disable query context cache #912

merged 1 commit into from
Sep 11, 2023

Conversation

sfc-gh-pfus
Copy link
Collaborator

@sfc-gh-pfus sfc-gh-pfus commented Sep 8, 2023 •
edited
Loading

Description

Provided parameter to disable query context cache

Checklist

  • Code compiles correctly
  • Run make fmt to fix inconsistent formats
  • Run make lint to get lint errors and fix all of them
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-911181-parameter-to-disable-qcc branch 2 times, most recently from c840a37 to 0ac0c35 Compare September 8, 2023 11:43
@sfc-gh-pfus sfc-gh-pfus marked this pull request as ready for review September 8, 2023 12:09
@sfc-gh-pfus sfc-gh-pfus requested a review from a team as a code owner September 8, 2023 12:09
sfc-gh-igarish
sfc-gh-igarish approved these changes Sep 8, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-igarish sfc-gh-igarish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-911181-parameter-to-disable-qcc branch from 0ac0c35 to d29124f Compare September 11, 2023 05:18
sfc-gh-dprzybysz
sfc-gh-dprzybysz reviewed Sep 11, 2023
View reviewed changes
doc.go Show resolved Hide resolved
dsn_test.go Show resolved Hide resolved
dsn_test.go Show resolved Hide resolved
@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-911181-parameter-to-disable-qcc branch from d29124f to 98cf098 Compare September 11, 2023 07:56
sfc-gh-dheyman-1
sfc-gh-dheyman-1 approved these changes Sep 11, 2023
View reviewed changes
dsn.go Show resolved Hide resolved
@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-911181-parameter-to-disable-qcc branch from 98cf098 to 643ecd6 Compare September 11, 2023 08:13
@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-911181-parameter-to-disable-qcc branch from 643ecd6 to fbcac60 Compare September 11, 2023 09:04
@sfc-gh-pfus sfc-gh-pfus merged commit 213a5ac into master Sep 11, 2023
23 checks passed
@sfc-gh-pfus sfc-gh-pfus deleted the SNOW-911181-parameter-to-disable-qcc branch September 11, 2023 09:40
@github-actions github-actions bot locked and limited conversation to collaborators Sep 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-igarish sfc-gh-igarish sfc-gh-igarish approved these changes

@sfc-gh-dprzybysz sfc-gh-dprzybysz sfc-gh-dprzybysz approved these changes

@sfc-gh-dheyman-1 sfc-gh-dheyman-1 sfc-gh-dheyman-1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfc-gh-pfus @sfc-gh-igarish @sfc-gh-dprzybysz @sfc-gh-dheyman-1