Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-899560: Support Array and Map type as java/scala Literal #47

Open
jbergeroncoveo opened this issue Aug 24, 2023 · 4 comments · May be fixed by #50
Open

SNOW-899560: Support Array and Map type as java/scala Literal #47

jbergeroncoveo opened this issue Aug 24, 2023 · 4 comments · May be fixed by #50

Comments

@jbergeroncoveo
Copy link

Arrays and Map literals are currently not supported in the java/scala codebase (an exception is thrown). They are currently supported in the python codebase (through dict and list) so it would be nice to have this feautre in java/scala.
@github-actions github-actions bot changed the title Support Array and Map type as java/scala Literal SNOW-899560: Support Array and Map type as java/scala Literal Aug 24, 2023
@jbergeroncoveo
Copy link
Author

Me again! I also made the changes for this feature (+ the tests) locally. Let me know how to open a branch/pr. Cheers.

@sfc-gh-jfreeberg
Copy link
Collaborator

Hi @jbergeroncoveo could you start by creating a PR from your fork? More info here: https://github.com/snowflakedb/snowpark-java-scala/blob/main/CONTRIBUTING.md

@jbergeroncoveo jbergeroncoveo linked a pull request Aug 29, 2023 that will close this issue
Open
2 tasks
@jbergeroncoveo
Copy link
Author

Hi @sfc-gh-jfreeberg I created a PR for both issues.

@jbergeroncoveo
Copy link
Author

Any update on this @sfc-gh-jfreeberg ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added Array and Map literals for the java scala codebase jbergeroncoveo/snowpark-java-scala
2 participants
@jbergeroncoveo @sfc-gh-jfreeberg