Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scala 213 #90

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Scala 213 #90

wants to merge 4 commits into from

Conversation

jjaderberg
Copy link

Hey Snowflake Team, we wanted to use the Snowpark Java API in a project but the Scala version got in our way. We have forked and bumped Scala to 2.13, and done minimal work to make it build. This lets us get on with our project.

We are not set up to run tests, and we think some of our changes may not be optimal. For example producing some additional copies of stuff (.toSeq). But FWIW here are our changes.
If nothing else you can count this as a +1 on the request to release these bindings for Scala 2.13 👍. Cheers!


Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-899949: Upgrade Scala to v2.13? #48

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

We updated Scala and Scalatest dependencies and then made everything compile.

Pre-review checklist

(For Snowflake employees)

  • This change has passed precommit
  • I have reviewed code coverage report for my PR in (Sonarqube)

jjaderberg and others added 3 commits June 6, 2024 14:39
Co-Authored-By: Martin Junghanns <martin.junghanns@neo4j.com>
Co-Authored-By: Paul Horn <paul.horn@neo4j.com>
Co-Authored-By: Jonatan Jäderberg <jonatan.jaderberg@neo4j.com>
Co-Authored-By: Martin Junghanns <martin.junghanns@neo4j.com>
Co-Authored-By: Martin Junghanns <martin.junghanns@neo4j.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SNOW-899949: Upgrade Scala to v2.13?
2 participants