Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1775480: Update cloudpickle dependency to allow >=3.0 #2538

Open
CSRessel opened this issue Oct 30, 2024 · 1 comment
Open

SNOW-1775480: Update cloudpickle dependency to allow >=3.0 #2538

CSRessel opened this issue Oct 30, 2024 · 1 comment
Assignees
Labels
feature New feature or request status-triage_done Initial triage done, will be further handled by the driver team

Comments

@CSRessel
Copy link

CSRessel commented Oct 30, 2024

What is the current behavior?

Cloudpickle dependency is pinned at <=2.2.1

What is the desired behavior?

Allow a wider dependency range for cloudpickle which includes versions >=3.0

How would this improve snowflake-snowpark-python?

The newer release is a requirement for the popular distributed computing library dask: https://github.com/dask/dask/blob/7ab0c93cfca0af130c778f9c1baec29a1f10b616/pyproject.toml#L33

Older versions of dask are compatible with the old cloudpickle versions, but there are many fixes and improvments in dask that have since been released since the 2024.08.1 release. A couple of those specific fixes that I would like to pick up are the crux of my issue.

Additionally, if support of python version 3.12 is intended at some point for the snowpark project, then the cloudpickle 3.0 version would likely be ideal (as this is the first release with official, tested support for python 3.12)

References, Other Background

I can see that the current snowpark pyproject references challenges on the support on the backend:

snowpark-python/setup.py

Lines 23 to 24 in 5a0aca2

"cloudpickle>=1.6.0,<=2.2.1,!=2.1.0,!=2.2.0;python_version<'3.11'",
"cloudpickle==2.2.1;python_version~='3.11'", # backend only supports cloudpickle 2.2.1 + python 3.11 at the moment

It would be helpful to understand if this is something that can't easily be supported by the snowpark library, or if this can be supported but will take some time. Thanks for you help!

@CSRessel CSRessel added the feature New feature or request label Oct 30, 2024
@github-actions github-actions bot changed the title Update cloudpickle dependency to allow >=3.0 SNOW-1775480: Update cloudpickle dependency to allow >=3.0 Oct 30, 2024
@sfc-gh-sghosh sfc-gh-sghosh self-assigned this Nov 12, 2024
@sfc-gh-sghosh
Copy link

Hello @CSRessel ,

Thanks for raising the issue, the support for python 3.12 with snowpark will be added tentatively end of Nov 2024.

Regards,
Sujan

@sfc-gh-sghosh sfc-gh-sghosh added the status-triage_done Initial triage done, will be further handled by the driver team label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request status-triage_done Initial triage done, will be further handled by the driver team
Projects
None yet
Development

No branches or pull requests

2 participants