Skip to content

Latest commit

 

History

History
72 lines (46 loc) · 2.69 KB

CONTRIBUTING.md

File metadata and controls

72 lines (46 loc) · 2.69 KB
Raw

How to contribute

jetcd is Apache 2.0 licensed and accepts contributions via GitHub pull requests. This document outlines some of the conventions on commit message formatting, contact points for developers, and other resources to help get contributions into etcd.

Email and chat

  • Email: etcd-dev
  • IRC: #etcd IRC channel on freenode.org

Getting started

  • Fork the repository on GitHub

Reporting bugs and creating issues

Reporting bugs is one of the best ways to contribute. However, a good bug report has some very specific qualities, so please read over our short document on reporting bugs before submitting a bug report. This document might contain links to known issues, another good reason to take a look there before reporting a bug.

Contribution flow

This is a rough outline of what a contributor's workflow looks like:

  • Create a topic branch from where to base the contribution. This is usually master.
  • Make commits of logical units.
  • Run license:format to make sure license headers are properly formatted (see below).
  • Make sure commit messages are in the proper format (see below).
  • Push changes in a topic branch to a personal fork of the repository.
  • Submit a pull request to etcd-io/jetcd.
  • The PR must receive a LGTM from at least one maintainer found in the MAINTAINERS file.

Thanks for contributing!

Code style

The coding style follows Google Java Style. See the style doc for details.

Please follow this style to make jetcd easy to review, maintain, and develop.

License headers

To make sure CI checks would pass please run

./mvnw license:format

and including any changes in PR before opening it.

Format of the commit message

We follow a rough convention for commit messages that is designed to answer two questions: what changed and why. The subject line should feature the what and the body of the commit should describe the why.

scripts: add the test-cluster command

this uses tmux to setup a test cluster that can easily be killed and started for debugging.

Fixes #38

The format can be described more formally as follows:

<subsystem>: <what changed>
<BLANK LINE>
<why this change was made>
<BLANK LINE>
<footer>

The first line is the subject and should be no longer than 70 characters, the second line is always blank, and other lines should be wrapped at 80 characters. This allows the message to be easier to read on GitHub as well as in various git tools.