diff --git a/flink-architecture-tests/flink-architecture-tests-test/src/main/java/org/apache/flink/architecture/rules/ITCaseRules.java b/flink-architecture-tests/flink-architecture-tests-test/src/main/java/org/apache/flink/architecture/rules/ITCaseRules.java index a3e651e7d12b2..c484d755c6feb 100644 --- a/flink-architecture-tests/flink-architecture-tests-test/src/main/java/org/apache/flink/architecture/rules/ITCaseRules.java +++ b/flink-architecture-tests/flink-architecture-tests-test/src/main/java/org/apache/flink/architecture/rules/ITCaseRules.java @@ -57,7 +57,7 @@ public class ITCaseRules { .doNotHaveModifier(ABSTRACT) .should() .haveSimpleNameEndingWith("ITCase")) - // FALSE by default however not every module has inheritors of AbstractTestBase + // FALSE by default since 0.23.0 however not every module has inheritors of AbstractTestBase .allowEmptyShould(true) .as( "Tests inheriting from AbstractTestBase should have name ending with ITCase"); @@ -130,6 +130,8 @@ public class ITCaseRules { miniClusterWithClientResourceClassRule()) .or( miniClusterWithClientResourceRule())))) + // FALSE by default since 0.23.0 however not every module has *ITCase tests + .allowEmptyShould(true) .as("ITCASE tests should use a MiniCluster resource or extension"); private static DescribedPredicate miniClusterWithClientResourceClassRule() { diff --git a/flink-formats/flink-hadoop-bulk/archunit-violations/83371291-f688-4eaf-a207-24981f1067f3 b/flink-formats/flink-hadoop-bulk/archunit-violations/83371291-f688-4eaf-a207-24981f1067f3 index 478fde0985b37..e69de29bb2d1d 100644 --- a/flink-formats/flink-hadoop-bulk/archunit-violations/83371291-f688-4eaf-a207-24981f1067f3 +++ b/flink-formats/flink-hadoop-bulk/archunit-violations/83371291-f688-4eaf-a207-24981f1067f3 @@ -1,3 +0,0 @@ -simple name of org.apache.flink.formats.hadoop.bulk.HadoopPathBasedPartFileWriterTest does not end with 'ITCase' in (HadoopPathBasedPartFileWriterTest.java:0) -simple name of org.apache.flink.formats.hadoop.bulk.committer.HadoopRenameCommitterHDFSTest does not end with 'ITCase' in (HadoopRenameCommitterHDFSTest.java:0) -simple name of org.apache.flink.formats.hadoop.bulk.committer.HadoopRenameCommitterLocalFSTest does not end with 'ITCase' in (HadoopRenameCommitterLocalFSTest.java:0) \ No newline at end of file diff --git a/flink-formats/flink-hadoop-bulk/src/test/java/org/apache/flink/formats/hadoop/bulk/HadoopPathBasedPartFileWriterTest.java b/flink-formats/flink-hadoop-bulk/src/test/java/org/apache/flink/formats/hadoop/bulk/HadoopPathBasedPartFileWriterITCase.java similarity index 98% rename from flink-formats/flink-hadoop-bulk/src/test/java/org/apache/flink/formats/hadoop/bulk/HadoopPathBasedPartFileWriterTest.java rename to flink-formats/flink-hadoop-bulk/src/test/java/org/apache/flink/formats/hadoop/bulk/HadoopPathBasedPartFileWriterITCase.java index 80ee85cd40c1e..ee476fa1c7f7e 100644 --- a/flink-formats/flink-hadoop-bulk/src/test/java/org/apache/flink/formats/hadoop/bulk/HadoopPathBasedPartFileWriterTest.java +++ b/flink-formats/flink-hadoop-bulk/src/test/java/org/apache/flink/formats/hadoop/bulk/HadoopPathBasedPartFileWriterITCase.java @@ -49,7 +49,7 @@ import static org.assertj.core.api.Assertions.assertThat; /** Base class for testing writing data to the hadoop file system with different configurations. */ -public class HadoopPathBasedPartFileWriterTest extends AbstractTestBase { +public class HadoopPathBasedPartFileWriterITCase extends AbstractTestBase { @Rule public final Timeout timeoutPerTest = Timeout.seconds(2000); @Test diff --git a/flink-formats/flink-hadoop-bulk/src/test/java/org/apache/flink/formats/hadoop/bulk/committer/HadoopRenameCommitterHDFSTest.java b/flink-formats/flink-hadoop-bulk/src/test/java/org/apache/flink/formats/hadoop/bulk/committer/HadoopRenameCommitterHDFSITCase.java similarity index 94% rename from flink-formats/flink-hadoop-bulk/src/test/java/org/apache/flink/formats/hadoop/bulk/committer/HadoopRenameCommitterHDFSTest.java rename to flink-formats/flink-hadoop-bulk/src/test/java/org/apache/flink/formats/hadoop/bulk/committer/HadoopRenameCommitterHDFSITCase.java index de6991e0c628c..2b3eddc82e9ae 100644 --- a/flink-formats/flink-hadoop-bulk/src/test/java/org/apache/flink/formats/hadoop/bulk/committer/HadoopRenameCommitterHDFSTest.java +++ b/flink-formats/flink-hadoop-bulk/src/test/java/org/apache/flink/formats/hadoop/bulk/committer/HadoopRenameCommitterHDFSITCase.java @@ -34,7 +34,7 @@ import java.io.IOException; /** Tests the behaviors of {@link HadoopRenameFileCommitter} with HDFS file system. */ -public class HadoopRenameCommitterHDFSTest extends AbstractFileCommitterTest { +public class HadoopRenameCommitterHDFSITCase extends AbstractFileCommitterTest { @ClassRule public static final TemporaryFolder CLASS_TEMPORARY_FOLDER = new TemporaryFolder(); @@ -56,7 +56,7 @@ public static void destroyHDFS() { hdfsCluster = null; } - public HadoopRenameCommitterHDFSTest(boolean override) throws IOException { + public HadoopRenameCommitterHDFSITCase(boolean override) throws IOException { super(override); } diff --git a/flink-formats/flink-hadoop-bulk/src/test/java/org/apache/flink/formats/hadoop/bulk/committer/HadoopRenameCommitterLocalFSTest.java b/flink-formats/flink-hadoop-bulk/src/test/java/org/apache/flink/formats/hadoop/bulk/committer/HadoopRenameCommitterLocalFSITCase.java similarity index 92% rename from flink-formats/flink-hadoop-bulk/src/test/java/org/apache/flink/formats/hadoop/bulk/committer/HadoopRenameCommitterLocalFSTest.java rename to flink-formats/flink-hadoop-bulk/src/test/java/org/apache/flink/formats/hadoop/bulk/committer/HadoopRenameCommitterLocalFSITCase.java index da93a5f1ff8a3..8e579864fb002 100644 --- a/flink-formats/flink-hadoop-bulk/src/test/java/org/apache/flink/formats/hadoop/bulk/committer/HadoopRenameCommitterLocalFSTest.java +++ b/flink-formats/flink-hadoop-bulk/src/test/java/org/apache/flink/formats/hadoop/bulk/committer/HadoopRenameCommitterLocalFSITCase.java @@ -27,9 +27,9 @@ import java.io.IOException; /** Tests the behaviors of {@link HadoopRenameFileCommitter} with local file system. */ -public class HadoopRenameCommitterLocalFSTest extends AbstractFileCommitterTest { +public class HadoopRenameCommitterLocalFSITCase extends AbstractFileCommitterTest { - public HadoopRenameCommitterLocalFSTest(boolean override) throws IOException { + public HadoopRenameCommitterLocalFSITCase(boolean override) throws IOException { super(override); }