Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove warning message for custom rules from iac --report #3287

Merged
merged 1 commit into from
Jun 6, 2022

Conversation

ipapast
Copy link
Contributor

@ipapast ipapast commented May 30, 2022

This commits removes the warning message we used to display when running snyk iac test --report, with custom rules (local or remote ones).
We now support custom rules when sharing results to the platform, so we remove this message.

CFG-1868

How to test

The ticket can be verified using https://github.com/snyk/custom-rules-examples/

  • Install snyk-iac-rules: https://github.com/snyk/snyk-iac-rules
  • Build a local bundle: snyk-iac-rules build
  • Run the rules to see them in the results: snyk iac test ./rules/CUSTOM-RULE-1/fixtures --rules=bundle.tar.gz
  • Run the rules and send them to the Platform: snyk-dev iac test ./rules/CUSTOM-RULE-1/fixtures --rules=bundle.tar.gz --report
  • Check that no warning message appears now.

Note: You will not see the issues from custom rules populated in the Snyk platform. This is still dependendent on another ticket, sending the results there.

Screenshots

no warning is displayed anymore

image

This commits removes the warning message we used to display when running `snyk iac test --report`, with custom rules (local or remote ones).
We now support custom rules when sharing results to the platform, so we remove this message.

CFG-1868
@ipapast ipapast changed the title fix: remove warning message from iac --report fix: remove warning message for custom rules from iac --report May 30, 2022
@ipapast ipapast requested a review from ofekatr May 30, 2022 15:22
@ipapast ipapast changed the title fix: remove warning message for custom rules from iac --report fix: remove warning message for custom rules from iac --report (do not merge yet) May 30, 2022
@ipapast ipapast marked this pull request as ready for review May 31, 2022 07:27
@ipapast ipapast requested a review from a team as a code owner May 31, 2022 07:27
@ipapast ipapast marked this pull request as draft June 1, 2022 13:31
@ipapast
Copy link
Contributor Author

ipapast commented Jun 1, 2022

converted to draft so that we merge it when we are ready.

@ipapast ipapast marked this pull request as ready for review June 6, 2022 10:29
@ipapast ipapast changed the title fix: remove warning message for custom rules from iac --report (do not merge yet) fix: remove warning message for custom rules from iac --report Jun 6, 2022
@ipapast ipapast merged commit a73145b into master Jun 6, 2022
@ipapast ipapast deleted the fix/remove-custom-rules-warning-cfg-1868 branch June 6, 2022 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants