-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove warning message for custom rules from iac --report #3287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commits removes the warning message we used to display when running `snyk iac test --report`, with custom rules (local or remote ones). We now support custom rules when sharing results to the platform, so we remove this message. CFG-1868
ipapast
changed the title
fix: remove warning message from iac --report
fix: remove warning message for custom rules from iac --report
May 30, 2022
ipapast
changed the title
fix: remove warning message for custom rules from iac --report
fix: remove warning message for custom rules from iac --report (do not merge yet)
May 30, 2022
ofekatr
approved these changes
Jun 1, 2022
converted to draft so that we merge it when we are ready. |
ipapast
changed the title
fix: remove warning message for custom rules from iac --report (do not merge yet)
fix: remove warning message for custom rules from iac --report
Jun 6, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commits removes the warning message we used to display when running
snyk iac test --report
, with custom rules (local or remote ones).We now support custom rules when sharing results to the platform, so we remove this message.
CFG-1868
How to test
The ticket can be verified using https://github.com/snyk/custom-rules-examples/
Note: You will not see the issues from custom rules populated in the Snyk platform. This is still dependendent on another ticket, sending the results there.
Screenshots
no warning is displayed anymore