Fix/v2 http proxy #3312
Merged
Fix/v2 http proxy #3312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxjeffos
approved these changes
Jun 10, 2022
Avishagp
approved these changes
Jun 10, 2022
PeterSchafer
force-pushed
the
fix/v2_http_proxy
branch
from
3745dc2 to
3f37725
Compare
Avishagp
reviewed
Jun 15, 2022
Avishagp
reviewed
Jun 15, 2022
PeterSchafer
force-pushed
the
fix/v2_http_proxy
branch
from
3f37725 to
da5aed1
Compare
Avishagp
approved these changes
Jun 15, 2022
PeterSchafer
force-pushed
the
fix/v2_http_proxy
branch
2 times, most recently
from
181ff05 to
208fb29
Compare
Signed-off-by: Peter Schäfer <101886095+PeterSchafer@users.noreply.github.com> chore: skip tests that cannot be satisfied with cliv2 Signed-off-by: Peter Schäfer <101886095+PeterSchafer@users.noreply.github.com> Signed-off-by: Peter Schäfer <101886095+PeterSchafer@users.noreply.github.com> Signed-off-by: Peter Schäfer <101886095+PeterSchafer@users.noreply.github.com> chore: override env variables instead of appending When creating the environment variables for the CLIv1 invocation ensure to override existing and not only append environment variables. Signed-off-by: Peter Schäfer <101886095+PeterSchafer@users.noreply.github.com>
PeterSchafer
force-pushed
the
fix/v2_http_proxy
branch
from
208fb29 to
78d0602
Compare
This was referenced May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In addition to the HTTPS_PROXY CLIv2 needs to specify the HTTP_PROXY environment variable.
Due to the change it is necessary to disable two HTTP proxy related tests. One can be enabled when error handling is improved and reasonable asserting can be done, the other seems to test for a specific needle (npm package in CLIv1) behavior, which is necessary to reproduce in CLIv2.