Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: print a warning when the user uses paths outside CWD #3313

Merged
merged 1 commit into from
Jun 13, 2022

Conversation

francescomari
Copy link
Contributor

What does this PR do?

This PR lets the snyk iac test command print a warning when the user provides one or more paths to scan that lay outside the current working directory.

How should this be manually tested?

Run the command without paths and check that the warning message is not displayed:

snyk iac test

Run the command with no paths laying outside the current working directory and check that the warning message is not displayed:

snyk iac test foo.tf bar.tf

Run the command with at least one path laying outside the current working directory and check that the warning message is displayed:

snyk iac test foo.tf bar.tf ../baz.tf

What are the relevant tickets?

CFG-1967

Screenshots

image

@github-actions
Copy link
Contributor

github-actions bot commented Jun 10, 2022

Warnings
⚠️

You've modified files in src/ directory, but haven't updated anything in test folder. Is there something that could be tested?

Generated by 🚫 dangerJS against 3389471

@francescomari francescomari marked this pull request as ready for review June 10, 2022 14:55
@francescomari francescomari requested a review from a team as a code owner June 10, 2022 14:55
@francescomari francescomari force-pushed the chore/paths-outside-cwd-warning-test branch from e95fcd4 to 4477974 Compare June 10, 2022 15:25
@francescomari francescomari force-pushed the chore/paths-outside-cwd-warning-test branch from 4477974 to 3389471 Compare June 13, 2022 09:52
Copy link
Contributor

@teodora-sandu teodora-sandu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants