chore: override env variables instead of appending #3323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating the environment variables for the CLIv1 invocation ensure to override existing and not only append environment variables. Signed-off-by: Peter Schäfer <101886095+PeterSchafer@users.noreply.github.com>
Avishagp
reviewed
Jun 15, 2022
maxjeffos
approved these changes
Jun 15, 2022
Avishagp
approved these changes
Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating the environment variables for CLIv1 invocation ensure to override existing ones and not only append environment variables.
Affected Environment Variables are:
What does this PR do?
It ensures that environment variables are unique and that there is no possible conflict/uncertainty between externally defined and internally set environment variables when being passed to CLIv1.
How should this be manually tested?
Run CLIv2 with --debug and use the following environments for testing:
env:
SNYK_HTTP_PROTOCOL_UPGRADE=0 SNYK_API=http://snyk.io/api/v1 HTTP_PROXY=http://127.0.0.1:3128expected:
dial tcp 127.0.0.1:3128: connect: connection refusedenv:
HTTPS_PROXY=https://127.0.0.1:312expected:
dial tcp 127.0.0.1:3128: connect: connection refusedenv:
NODE_EXTRA_CA_CERTS=./hereNOT expected:
Warning: Ignoring extra certs from./here, load failed: error:02001002:system library:fopen:No such file or directory