Chore/cliv2 case insensitive env vars #3364
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterSchafer
changed the base branch from
master
to
chore/cliv2_noproxy_filtering
PeterSchafer
force-pushed
the
chore/cliv2_case_insensitive_env_vars
branch
from
bee004d to
420a72c
Compare
PeterSchafer
changed the base branch from
chore/cliv2_noproxy_filtering
to
master
avoid accidental and purposeful redirecting of traffic between cliv1 and cliv2 Signed-off-by: Peter Schäfer <101886095+PeterSchafer@users.noreply.github.com> Signed-off-by: Peter Schäfer <101886095+PeterSchafer@users.noreply.github.com> Signed-off-by: Peter Schäfer <101886095+PeterSchafer@users.noreply.github.com> chore: support different casing for proxy related env variables Signed-off-by: Peter Schäfer <101886095+PeterSchafer@users.noreply.github.com> Signed-off-by: Peter Schäfer <101886095+PeterSchafer@users.noreply.github.com>
PeterSchafer
force-pushed
the
chore/cliv2_case_insensitive_env_vars
branch
from
420a72c to
870d1e7
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Some environment variables, especially around proxy configuration, can have either upper or lower case names. Most environments support this, like node and golang. This PR introduces the ability to also handle both cases of variables in CLIv2 when preparing the environment to launch CLIv1.
Example:
HTTP_PROXY = http_proxy
How should this be manually tested?
Using CLIv2 with either environment variable below, should behave the same.
HTTPS_PROXY=http://127.0.0.1:3128
https_proxy=http://127.0.0.1:3128