Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: replace needle get request for curl on kind setup #461

Merged
merged 1 commit into from
Apr 28, 2020
Merged

chore: replace needle get request for curl on kind setup #461

merged 1 commit into from
Apr 28, 2020

Conversation

agranado2k
Copy link
Contributor

@agranado2k agranado2k commented Apr 28, 2020 •
edited
Loading

  • Tests written and linted ℹ︎
  • Documentation written ℹ︎
  • Commit history is tidy ℹ︎

What this does

Because the new nodejs version 12.16.3 created a issue with needle for request that need to be redirected. The test suites that need download KinD binary were breaking during the test. To workaround that we replaced the needle get request for a curl command.

Notes for the reviewer

The needle issue was reported here.

@agranado2k agranado2k self-assigned this Apr 28, 2020
@agranado2k agranado2k marked this pull request as ready for review April 28, 2020 17:11
@agranado2k agranado2k requested a review from a team as a code owner April 28, 2020 17:11
ivanstanev
ivanstanev previously approved these changes Apr 28, 2020
View reviewed changes
Copy link
Contributor

@ivanstanev ivanstanev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a small note that it should be 12.16.3 instead of 12.16.13 in the commit description!

chore: replace needle get request for curl on kind setup
d122374 
 The last nodejs version, 12.16.3, created an issue with needle lib for redirect requests, that was breaking the test suites which needed to download a KinD binary. To workaround the issue the needle get request was replaced for a curl command on KinD setup to download KinD binary.
@agranado2k agranado2k force-pushed the chore/use_curl_to_download_kind branch from 810fd87 to d122374 Compare April 28, 2020 17:25
@github-actions
Copy link

github-actions bot commented Apr 28, 2020 •
edited by agranado2k
Loading

Expected release notes (by @agranado2k)

fixes:
retry API requests when receiving error code EAI_AGAIN (de32f36)

others (will not be included in Semantic-Release notes):
replace needle get request for curl on kind setup (810fd87)
extract the condition for retry request to the new function (e89c778)
Update README and snyk-monitor README (29a2bf2)
bump release-notes-preview GH action to 1.6.1 (6855c7d)
fix bad name on type in kind.test.ts due to bad merge (4cf80d2)
add type hints when constructing dependency graph payload (ab9d675)
do not shorten the type for the dependency graph payload (853f47d)
assert the payloads transmitted during system tests (94f69b7)
wait for deployment to appear before continuing system tests (205d8e4)

  • I hereby acknowledge these release notes are 🥙 AWESOME 🥙

@agranado2k agranado2k merged commit 00b3d88 into staging Apr 28, 2020
@agranado2k agranado2k deleted the chore/use_curl_to_download_kind branch April 28, 2020 17:33
@snyksec
Copy link

snyksec commented Apr 28, 2020

🎉 This PR is included in version 1.27.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@snyk-bot snyk-bot mentioned this pull request Nov 30, 2022
Open
@Sladey01 Sladey01 mentioned this pull request Nov 30, 2022
Open
This was referenced Nov 30, 2022
Open
Open
@Omrisnyk Omrisnyk mentioned this pull request Nov 30, 2022
Open
@Tatianamsnyk Tatianamsnyk mentioned this pull request Nov 30, 2022
Open
@abinda-snyk abinda-snyk mentioned this pull request Dec 1, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Dec 1, 2022
Open
@riddopic riddopic mentioned this pull request Dec 1, 2022
Open
@kilaruoleh-def kilaruoleh-def mentioned this pull request Dec 1, 2022
Open
This was referenced Dec 1, 2022
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanstanev ivanstanev ivanstanev approved these changes

Assignees

@agranado2k agranado2k

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agranado2k @snyksec @ivanstanev