Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: package missing error #231

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Conversation

MarcusArdelean
Copy link
Contributor

What does this PR do?

A bunch of projects were failing with Required packages missing: <package_name>. This was happening due to some symbol -, _, . miss-matching in the package names. The solution is to canonicalize the package names before comparing them.

@MarcusArdelean MarcusArdelean self-assigned this Jan 29, 2024
@MarcusArdelean MarcusArdelean requested a review from a team as a code owner January 29, 2024 09:17
@CLAassistant
Copy link

CLAassistant commented Jan 29, 2024

CLA assistant check
All committers have signed the CLA.

@MarcusArdelean MarcusArdelean changed the title fix: [SUP-2395] package missing error fix: package missing error Jan 29, 2024
Copy link
Contributor

@gemaxim gemaxim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MarcusArdelean MarcusArdelean merged commit 80c5f15 into main Jan 29, 2024
22 checks passed
@MarcusArdelean MarcusArdelean deleted the fix/SUP-2395/package_missing_error branch January 29, 2024 12:38
@snyksec
Copy link

snyksec commented Jan 29, 2024

🎉 This PR is included in version 2.0.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants