fix: add support for dev/alpha/beta/rc python versions #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcusArdelean
commented
Feb 23, 2024
Comment on lines
+150
to
+158
| operator = { | ||
| ">": gt, | ||
| "==": eq, | ||
| "<": lt, | ||
| "<=": le, | ||
| ">=": ge, | ||
| '!=': ne, | ||
| }[parsed_operator] | ||
| } | ||
| operator_func = operator.get(parsed_operator) |
There was a problem hiding this comment.
Changed the way the operator function was established. It's pretty confusing to create the dictionary and extract values from it in one go. I think that is even more confusing for someone that doesn't work with Python on a daily basis.
…ev-alpha-beta-rc-python-versions
JCheung2004
approved these changes
Mar 6, 2024
MarcusArdelean
deleted the
fix/add-support-for-dev-alpha-beta-rc-python-versions
branch
|
🎉 This PR is included in version 2.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds support for development, alpha, beta and release candidate python versions.
Now we will support the following python versions:
3.9.23.9.*3.9.dev03.9.a13.9.b23.9.rc01Some Context
Some clients are using Poetry in order to generate a requirements.txt file. By default, poetry uses development versions to restrict the instalation of some packages, and until now we were not handling those versions only stable releases and wildcard versions.
What are the relevant tickets?
Support ticket SUP-2503