From af0eeb17cd5d9499e0f4a38b4990c1e3c7b86b11 Mon Sep 17 00:00:00 2001 From: "Gorcha (Danny Smith)" Date: Mon, 22 Feb 2021 15:22:02 +1100 Subject: [PATCH] Remove `is_vector_s3()` method, close #19. --- DESCRIPTION | 2 +- NEWS.md | 2 ++ R/pillar.R | 3 --- R/zzz.R | 1 - 4 files changed, 3 insertions(+), 5 deletions(-) diff --git a/DESCRIPTION b/DESCRIPTION index 708e2fd..682f91a 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -1,6 +1,6 @@ Package: dialr Title: Parse, Format, and Validate International Phone Numbers -Version: 0.3.2.9000 +Version: 0.3.2.9001 Authors@R: c(person(given = "Danny", family = "Smith", diff --git a/NEWS.md b/NEWS.md index 5a49f46..5a5d50e 100644 --- a/NEWS.md +++ b/NEWS.md @@ -2,6 +2,8 @@ * Move rJava initialisation to `.onLoad()` instead of `.onAttach()` (#16). Since dialr is a wrapper for a Java package, rJava has to initialise Java before it will work. Previously, users had to attach dialr with `library(dialr)` to properly initialise Java. Now rJava is initialised when the package is loaded/referenced, so dialr functions can now be used with the `::` notation (e.g. `dialr::phone()`) without a preceding call to `library()`. +* Remove `is_vector_s3()` method at the pillar maintainer's request (#19). + # dialr 0.3.2 * Bump minimum supported version following R 4.0.0 release. diff --git a/R/pillar.R b/R/pillar.R index f339af9..bbc7776 100644 --- a/R/pillar.R +++ b/R/pillar.R @@ -13,9 +13,6 @@ pillar_shaft.phone <- function(x, ...) { pillar::new_pillar_shaft_simple(out, align = "right") } -# Dynamically exported, see zzz.R -is_vector_s3.phone <- function(x) TRUE - # Dynamically exported, see zzz.R obj_sum.phone <- function(x) { paste0("phone [", length(x), "]") diff --git a/R/zzz.R b/R/zzz.R index 2ff85ac..ab64da6 100644 --- a/R/zzz.R +++ b/R/zzz.R @@ -15,7 +15,6 @@ # Dynamically register S3 methods if pillar is installed register_s3_method("pillar", "pillar_shaft", "phone") register_s3_method("pillar", "type_sum", "phone") - register_s3_method("pillar", "is_vector_s3", "phone") register_s3_method("pillar", "obj_sum", "phone") # initialise rJava