From 27fa6949f38896e18a6ef426516359f8d54e7db6 Mon Sep 17 00:00:00 2001 From: "Chris West (Faux)" Date: Fri, 13 Dec 2019 10:51:25 +0000 Subject: [PATCH] refactor: remove indexof dependency This is a polyfill for indexOf(), which we use literally everywhere else. --- lib/socket.js | 3 +-- package-lock.json | 9 +++++---- package.json | 1 - 3 files changed, 6 insertions(+), 7 deletions(-) diff --git a/lib/socket.js b/lib/socket.js index 3322c361b..85951e6a1 100644 --- a/lib/socket.js +++ b/lib/socket.js @@ -1,7 +1,6 @@ const transports = require("./transports/index"); const Emitter = require("component-emitter"); const debug = require("debug")("engine.io-client:socket"); -const index = require("indexof"); const parser = require("engine.io-parser"); const parseuri = require("parseuri"); const parseqs = require("parseqs"); @@ -643,7 +642,7 @@ class Socket extends Emitter { let i = 0; const j = upgrades.length; for (; i < j; i++) { - if (~index(this.transports, upgrades[i])) + if (~this.transports.indexOf(upgrades[i])) filteredUpgrades.push(upgrades[i]); } return filteredUpgrades; diff --git a/package-lock.json b/package-lock.json index 125b90b6f..abbd1cf9f 100644 --- a/package-lock.json +++ b/package-lock.json @@ -3552,7 +3552,7 @@ "cookie": "0.3.1", "cors": "~2.8.5", "debug": "~4.1.0", - "engine.io-parser": "git+https://github.com/socketio/engine.io-parser.git#v4", + "engine.io-parser": "~4.0.0-alpha.0", "ws": "^7.1.2" }, "dependencies": { @@ -3563,8 +3563,8 @@ "dev": true }, "engine.io-parser": { - "version": "git+https://github.com/socketio/engine.io-parser.git#7f5a903f91c4851e5807595adc50964474260048", - "from": "git+https://github.com/socketio/engine.io-parser.git#v4", + "version": "4.0.0-alpha.0", + "resolved": "git+https://github.com/socketio/engine.io-parser.git#7f5a903f91c4851e5807595adc50964474260048", "dev": true, "requires": { "after": "0.8.2", @@ -5874,7 +5874,8 @@ "indexof": { "version": "0.0.1", "resolved": "https://registry.npmjs.org/indexof/-/indexof-0.0.1.tgz", - "integrity": "sha1-gtwzbSMrkGIXnQWrMpOmYFn9Q10=" + "integrity": "sha1-gtwzbSMrkGIXnQWrMpOmYFn9Q10=", + "dev": true }, "infer-owner": { "version": "1.0.4", diff --git a/package.json b/package.json index a938a66e7..cfcdc76a6 100644 --- a/package.json +++ b/package.json @@ -28,7 +28,6 @@ "debug": "~4.1.0", "engine.io-parser": "~4.0.0-alpha.0", "has-cors": "1.1.0", - "indexof": "0.0.1", "parseqs": "0.0.5", "parseuri": "0.0.5", "ws": "~7.2.1",