From d134feeaa615afc4cbe0aa45aa4344c899b65df0 Mon Sep 17 00:00:00 2001 From: Damien Arrachequesne Date: Thu, 14 Jan 2021 01:05:16 +0100 Subject: [PATCH] feat: add missing ws options Reference: https://github.com/websockets/ws/blob/master/doc/ws.md#new-websocketaddress-protocols-options Related: - https://github.com/socketio/engine.io-client/issues/574 - https://github.com/socketio/engine.io-client/issues/615 --- lib/transports/websocket.js | 7 ++++++- lib/util.js | 4 +++- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/lib/transports/websocket.js b/lib/transports/websocket.js index 1c7ea92ad..39a6c9fef 100644 --- a/lib/transports/websocket.js +++ b/lib/transports/websocket.js @@ -67,7 +67,12 @@ class WS extends Transport { "ca", "ciphers", "rejectUnauthorized", - "localAddress" + "localAddress", + "protocolVersion", + "origin", + "maxPayload", + "family", + "checkServerIdentity" ); if (this.opts.extraHeaders) { diff --git a/lib/util.js b/lib/util.js index fc30f0828..61c00b560 100644 --- a/lib/util.js +++ b/lib/util.js @@ -1,6 +1,8 @@ module.exports.pick = (obj, ...attr) => { return attr.reduce((acc, k) => { - acc[k] = obj[k]; + if (obj.hasOwnProperty(k)) { + acc[k] = obj[k]; + } return acc; }, {}); };