Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: auth property on Socket is public #1455

Closed
wants to merge 1 commit into from
Closed

fix: auth property on Socket is public #1455

wants to merge 1 commit into from

Conversation

theoludwig
Copy link
Contributor

Note: the socket.io.js file is the generated output of make socket.io.js, and should not be manually modified.

The kind of change this PR does introduce

  • a bug fix
  • a new feature
  • an update to the documentation
  • a code change that improves performance
  • other

Current behaviour

Currently the auth property on the Socket object is a private TypeScript property.
In the docs, it says that we can change the auth property. (see: https://socket.io/docs/v3/client-initialization/#auth)
But currently we can't in TypeScript.
image

New behaviour

Now the auth property is public, so we can update it.

@theoludwig
Copy link
Contributor Author

I don't think, that the CI is failing because of this PR.
Is there is any reason that the auth option is private ? @darrachequesne

darrachequesne pushed a commit that referenced this pull request Mar 31, 2021
@darrachequesne
Copy link
Member

Merged as c150223. Thanks!

@theoludwig theoludwig deleted the fix/public-auth-property branch April 1, 2021 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants