fix: auth
property on Socket is public
#1455
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: the
socket.io.js
file is the generated output ofmake socket.io.js
, and should not be manually modified.The kind of change this PR does introduce
Current behaviour
Currently the
![image](https://user-images.githubusercontent.com/25207499/111870495-63072380-8985-11eb-8526-89ec0162a086.png)
auth
property on theSocket
object is aprivate
TypeScript property.In the docs, it says that we can change the
auth
property. (see: https://socket.io/docs/v3/client-initialization/#auth)But currently we can't in TypeScript.
New behaviour
Now the
auth
property ispublic
, so we can update it.