Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update definition to match wrapper.mjs #1456

Closed
wants to merge 1 commit into from

Conversation

alexxyzeng
Copy link
Contributor

The kind of change this PR does introduce

  • a bug fix

Current behaviour

The file wraper.mjs is currently like:

export default io;

1617011194602

but index.ts does not export default lookup(io), so there is no type definition for this export default behaviour.

New behaviour

add export default lookup to index.ts; when it's compiled, there will be a export default definitiion in the build/index.d.ts file.

1617011090471

@darrachequesne
Copy link
Member

Merged as 48f573f. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants