Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing requestTimeout to EngineOptions #1467

Merged
merged 1 commit into from
May 16, 2021

Conversation

nabati
Copy link
Contributor

@nabati nabati commented May 12, 2021

The kind of change this PR does introduce

  • a bug fix
  • a new feature
  • an update to the documentation
  • a code change that improves performance
  • other

Current behaviour

Missing requestTimeout property type

New behaviour

Adds requestTimeout property type

Other information (e.g. related issues)

@darrachequesne darrachequesne merged commit c8dfbb1 into socketio:master May 16, 2021
@darrachequesne
Copy link
Member

@nabati thanks 👍

@darrachequesne darrachequesne added this to the 4.1.0 milestone May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants