Fixed binary events being mark as regular events #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duncanleo
added a commit
to taskade/socket.io-emitter
that referenced
this pull request
Jun 11, 2020
|
@jvictorsoto thanks a lot, sorry for the delay... |
darrachequesne
pushed a commit
that referenced
this pull request
Dec 29, 2020
So that the emitter can send binary payloads to a Socket.IO server (only applies to `socket.io@2.1.0...2.x`). Related: - socketio/socket.io-parser@dc4f475 - socketio/socket.io@f48a06c Co-authored-by: Victor Soto <jesus_victor.soto_munoz@nokia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Socket.io-emitter is marking all emitted events as regular events, included check for marking them as binary events if needed.