Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use of global in binary check fails in angular 6 applications #87

Closed
psylum opened this issue May 25, 2018 · 1 comment
Closed

use of global in binary check fails in angular 6 applications #87

psylum opened this issue May 25, 2018 · 1 comment

Comments

@psylum
Copy link

psylum commented May 25, 2018

Ideally this package should follow socketio/socket.io-client and also depend on has-binary2 which has been patched for this issue. Otherwise a patch is discussed that may be suitable.

See discussion in socketio/socket.io-client#1166 and socketio/socket.io-client#1206.
@darrachequesne
Copy link
Member

Closed by b47efb2 (and included in socket.io-parser>=3.3.0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@psylum @darrachequesne