Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix NodeNext module resolution compatibility #4625

Closed
wants to merge 1 commit into from

Conversation

igorls
Copy link
Contributor

@igorls igorls commented Feb 9, 2023

The kind of change this PR does introduce

  • a bug fix
  • a new feature
  • an update to the documentation
  • a code change that improves performance
  • other

Current behavior

Types are not found when typescript moduleResolution is set to NodeNext, issue #4621

New behavior

Works normally with NodeNext

Other information (e.g. related issues)

Must be merged together with the engine.io PR socketio/engine.io#669

darrachequesne pushed a commit that referenced this pull request Feb 20, 2023
The import added in [1] was invalid, because it used an non-exported
class.

Related: #4621

[1]: d4a9b2c
@darrachequesne
Copy link
Member

Merged as d0b22c6. Thanks!

haneenmahd pushed a commit to haneenmahd/socket.io that referenced this pull request Apr 15, 2023
The import added in [1] was invalid, because it used an non-exported
class.

Related: socketio#4621

[1]: socketio@d4a9b2c
dzad pushed a commit to dzad/socket.io that referenced this pull request May 29, 2023
The import added in [1] was invalid, because it used an non-exported
class.

Related: socketio#4621

[1]: socketio@6652a3f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants