Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typings): accept an Http2Server non-secure as http-server instance #4853

Merged
merged 3 commits into from
Nov 22, 2023

Conversation

0x0a0d
Copy link
Contributor

@0x0a0d 0x0a0d commented Oct 16, 2023

http server should accept non-secure http2server instance

@darrachequesne
Copy link
Member

Hi! Out of curiosity, what is your use case? (since there are no browsers known that support unencrypted HTTP/2)

@0x0a0d
Copy link
Contributor Author

0x0a0d commented Oct 17, 2023

We can use it not only on browser but also on server to server that don't require TLS due to performance

@darrachequesne darrachequesne merged commit 8c9ebc3 into socketio:main Nov 22, 2023
8 checks passed
@darrachequesne
Copy link
Member

@0x0a0d thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants