Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] BroadcastWithAck behavior #4878

Merged
merged 7 commits into from
Jan 2, 2024
Merged

[FIX] BroadcastWithAck behavior #4878

merged 7 commits into from
Jan 2, 2024

Conversation

BCCSTeam
Copy link
Contributor

@BCCSTeam BCCSTeam commented Nov 25, 2023

The kind of change this PR does introduce

  • a bug fix
  • a new feature
  • an update to the documentation
  • a code change that improves performance
  • other

Current behavior

On remote sockets don't call callback with arguments.
Returns null as error and data.

New behavior

On remote sockets with call callback with arguments.
Now it returns error and data from callback.

Other information (e.g. related issues)

@BCCSTeam BCCSTeam changed the title [FIX] [FIX] BroadcastWithAck behavior Nov 25, 2023
@darrachequesne darrachequesne merged commit df8e70f into socketio:main Jan 2, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants