Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

json3 deprecated #476

Comments

@sidoruk-sv
Copy link

sidoruk-sv commented May 31, 2019

https://www.npmjs.com/package/json3

JSON 3 is deprecated and no longer maintained. Please don't use it in new projects, and migrate existing projects to use the native JSON.parse and JSON.stringify instead.

@brycekahle
Copy link
Contributor

I believe its use as a polyfill is still valid for sockjs. We still target some of the browsers that needed the polyfill in the first place.

@DaSchTour
Copy link

polyfills generally are not part of a library but are added on demand but the user of a library. This is currently forcing everybody to ship json3 to millions of users that don't need it. I think it will save a lot of carbon dioxide to not ship it to the 99.9% of users that doesn't need it.
Just let the user include https://polyfill.io/v3/ with JSON and only the few users that really need it will have to download JSON polyfill.

@brycekahle
Copy link
Contributor

Removing JSON3 would be a breaking change for some users, which is not something I'm interested in doing at the moment.

@DaSchTour
Copy link

That's why there is semver I guess.

@jonkoops
Copy link

@brycekahle What is your intention in regards to browser support in the future? Will support for IE below v11 be dropped at some point?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment