Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dtype conversion issue #314

Open
vankesteren opened this issue Aug 29, 2024 · 0 comments · Fixed by #313
Open

Dtype conversion issue #314

vankesteren opened this issue Aug 29, 2024 · 0 comments · Fixed by #313
Assignees
Milestone

Comments

@vankesteren
Copy link
Member

@qubixes you had excellent foresight

metasyn/metasyn/var.py

Lines 78 to 79 in c102905

This method uses internal polars methods, so this might break at some
point.

it broke. I fixed it for the categorical dtypes in #313, but we might want to do something a bit more stable / custom like have a direct lookup table from polars dtypes (e.g., pl.Categorical) to metasyn.

@vankesteren vankesteren reopened this Sep 2, 2024
@qubixes qubixes added this to the Metasyn 1.1 milestone Oct 9, 2024
@qubixes qubixes self-assigned this Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants