Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release assets as an output #152

Closed
m4heshd opened this issue Aug 26, 2021 · 1 comment · Fixed by #185
Closed

Add release assets as an output #152

m4heshd opened this issue Aug 26, 2021 · 1 comment · Fixed by #185

Comments

@m4heshd
Copy link

m4heshd commented Aug 26, 2021

This is an extension to #9.

It would be really useful if outputs contained something like assets which should be an array containing each response object from every asset upload. I think you can safely remove the uploader property which is unnecessary IMO.

I'm not sure about the data type though. I think it should be a JSON string which then the user can use with fromJSON(). Not sure if it's possible to set it as a proper sequence when setting the output. It's a valuable piece of data to have either way.

I'd do a PR myself but can't put the time aside at the moment. 🥵

@ncfavier
Copy link
Contributor

I implemented this in #185

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants