From 17471231cf886fa818ad69361e2757093d79c839 Mon Sep 17 00:00:00 2001 From: Jakub Piasecki Date: Fri, 28 Jun 2024 08:23:25 +0200 Subject: [PATCH] Use newer constructor for all Gesture Handler events on Android (#2967) ## Description Updates events to use the newer constructor with `surfaceId`. ## Test plan Check the example app --- .../swmansion/gesturehandler/react/RNGestureHandlerEvent.kt | 4 +++- .../gesturehandler/react/RNGestureHandlerStateChangeEvent.kt | 4 +++- .../gesturehandler/react/RNGestureHandlerTouchEvent.kt | 3 ++- 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/android/src/main/java/com/swmansion/gesturehandler/react/RNGestureHandlerEvent.kt b/android/src/main/java/com/swmansion/gesturehandler/react/RNGestureHandlerEvent.kt index f392c47f15..71a6937e54 100644 --- a/android/src/main/java/com/swmansion/gesturehandler/react/RNGestureHandlerEvent.kt +++ b/android/src/main/java/com/swmansion/gesturehandler/react/RNGestureHandlerEvent.kt @@ -9,6 +9,7 @@ package com.swmansion.gesturehandler.react import androidx.core.util.Pools import com.facebook.react.bridge.Arguments import com.facebook.react.bridge.WritableMap +import com.facebook.react.uimanager.UIManagerHelper import com.facebook.react.uimanager.events.Event import com.swmansion.gesturehandler.core.GestureHandler import com.swmansion.gesturehandler.react.eventbuilders.GestureHandlerEventDataBuilder @@ -29,7 +30,8 @@ class RNGestureHandlerEvent private constructor() : Event dataBuilder: GestureHandlerEventDataBuilder, useNativeAnimatedName: Boolean ) { - super.init(handler.view!!.id) + val view = handler.view!! + super.init(UIManagerHelper.getSurfaceId(view), view.id) this.dataBuilder = dataBuilder this.useTopPrefixedName = useNativeAnimatedName coalescingKey = handler.eventCoalescingKey diff --git a/android/src/main/java/com/swmansion/gesturehandler/react/RNGestureHandlerStateChangeEvent.kt b/android/src/main/java/com/swmansion/gesturehandler/react/RNGestureHandlerStateChangeEvent.kt index c51ac4514f..1c0bb003f9 100644 --- a/android/src/main/java/com/swmansion/gesturehandler/react/RNGestureHandlerStateChangeEvent.kt +++ b/android/src/main/java/com/swmansion/gesturehandler/react/RNGestureHandlerStateChangeEvent.kt @@ -9,6 +9,7 @@ package com.swmansion.gesturehandler.react import androidx.core.util.Pools import com.facebook.react.bridge.Arguments import com.facebook.react.bridge.WritableMap +import com.facebook.react.uimanager.UIManagerHelper import com.facebook.react.uimanager.events.Event import com.swmansion.gesturehandler.core.GestureHandler import com.swmansion.gesturehandler.react.eventbuilders.GestureHandlerEventDataBuilder @@ -24,7 +25,8 @@ class RNGestureHandlerStateChangeEvent private constructor() : Event, ) { - super.init(handler.view!!.id) + val view = handler.view!! + super.init(UIManagerHelper.getSurfaceId(view), view.id) this.dataBuilder = dataBuilder this.newState = newState this.oldState = oldState diff --git a/android/src/main/java/com/swmansion/gesturehandler/react/RNGestureHandlerTouchEvent.kt b/android/src/main/java/com/swmansion/gesturehandler/react/RNGestureHandlerTouchEvent.kt index 25ec4c40e8..98501d7337 100644 --- a/android/src/main/java/com/swmansion/gesturehandler/react/RNGestureHandlerTouchEvent.kt +++ b/android/src/main/java/com/swmansion/gesturehandler/react/RNGestureHandlerTouchEvent.kt @@ -11,7 +11,8 @@ class RNGestureHandlerTouchEvent private constructor() : Event> init(handler: T) { - super.init(UIManagerHelper.getSurfaceId(handler.view), handler.view!!.id) + val view = handler.view!! + super.init(UIManagerHelper.getSurfaceId(view), view.id) extraData = createEventData(handler) coalescingKey = handler.eventCoalescingKey }