Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RNNativeViewHandler implementation on macOS #2697

Closed
jfedak opened this issue Dec 15, 2023 · 2 comments · Fixed by #3004
Closed

RNNativeViewHandler implementation on macOS #2697

jfedak opened this issue Dec 15, 2023 · 2 comments · Fixed by #3004

Comments

@jfedak
Copy link
Contributor

jfedak commented Dec 15, 2023

Description

Right now, we don't implement RNNativeViewHandler on macOS. This is quite important, because compotents like GH button require this handler to work. It is not as simple as it is on iOS, as there is no addTarget method in NSControl.

The second thing to consider here are methods pointInside and hitTest in RNGestureHandlerButton.m. It seems that the signature differs between iOS and macOS, so we need to override the correct methods.

Steps to reproduce

Snack or a link to a repository

Gesture Handler version

React Native version

Platforms

MacOS

JavaScript runtime

None

Workflow

None

Architecture

None

Build type

None

Device

None

Device model

No response

Acknowledgements

Yes

Copy link

Hey! 👋

It looks like you've omitted a few important sections from the issue template.

Please complete Steps to reproduce, Snack or a link to a repository, Gesture Handler version and React Native version sections.

Copy link

Hey! 👋

The issue doesn't seem to contain a minimal reproduction.

Could you provide a snack or a link to a GitHub repository under your username that reproduces the problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant