Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Few latest release versions(2.15.0, 2.16.0, 2.16.1, 2.16.2) causing iOS build crash, version 2.14.1 is fine #2927

Closed
badeggg opened this issue May 30, 2024 · 1 comment
Labels
Platform: iOS This issue is specific to iOS Repro provided A reproduction with a snack or repo is provided

Comments

@badeggg
Copy link

badeggg commented May 30, 2024

Description

When I update react-native-gesture-handler version, iOS build crashes. 2.14.1 --> 2.15.0/2.16.0/2.16.1/2.16.2
After a little digging, the causing line is here. Since I noticed that when I change this line back to

        auto shadowNode = arguments[0].asObject(runtime).getHostObject<ShadowNodeWrapper>(runtime)->shadowNode;

which is identical in version 2.14.1 here, iOS builds ok.

Crash report view:
image

Crash report file:
c1.txt

Steps to reproduce

  1. Clone https://github.com/Expensify/App, I am on 2a7d5d497ebec61171c7033ff85cdd0731d710c5 which is main branch status for now
  2. Upgrade react-native-gesture-handler version to version 2.16.2
  3. Follow steps to start iOS app
  4. You will notice build crash

Snack or a link to a repository

https://github.com/badeggg/expensify-app

Gesture Handler version

2.16.2

React Native version

0.73.4

Platforms

iOS

JavaScript runtime

None

Workflow

None

Architecture

None

Build type

None

Device

None

Device model

No response

Acknowledgements

Yes

@j-piasecki
Copy link
Member

Our current policy regarding the new architecture support is to support only the most recent version, which at the time of writing is 0.74. The crash you're describing is caused by a breaking change between RN 0.73 and 0.74.

I see you were able to work around it by using a patch. I would recommend using that until the PR that upgrades Expensify to 0.74 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform: iOS This issue is specific to iOS Repro provided A reproduction with a snack or repo is provided
Projects
None yet
Development

No branches or pull requests

2 participants