From 410646fdcb8a87fbac7bd433f4711906c8652ce6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ignacy=20=C5=81=C4=85tka?= Date: Tue, 2 Jul 2024 14:35:39 +0200 Subject: [PATCH 1/5] change check-integrity naming scheme --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 42a3e66dd2..72459756e3 100644 --- a/package.json +++ b/package.json @@ -15,7 +15,7 @@ "lint:js": "eslint --ext '.js,.ts,.tsx' src/ example/src FabricExample/src MacOSExample/src && yarn prettier --check './{src,example,FabricExample,MacOSExample}/**/*.{js,jsx,ts,tsx}'", "lint:js-root": "eslint --ext '.js,.ts,.tsx' src/ && yarn prettier --check './src/**/*.{js,jsx,ts,tsx}'", "lint:android": "./android/gradlew -p android spotlessCheck -q", - "checkIntegrity": "(cd ./FabricExample/android && ./gradlew generateCodegenArtifactsFromSchema -PskipCodegenCopyTask) && (cd ./android && ./gradlew checkIntegrityBetweenArchitectures)" + "check-integrity": "(cd ./FabricExample/android && ./gradlew generateCodegenArtifactsFromSchema -PskipCodegenCopyTask) && (cd ./android && ./gradlew checkIntegrityBetweenArchitectures)" }, "react-native": "src/index.ts", "main": "lib/commonjs/index.js", From 83656ba23862594f83da240b26760461cdbee6dc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ignacy=20=C5=81=C4=85tka?= Date: Tue, 2 Jul 2024 14:39:22 +0200 Subject: [PATCH 2/5] change name for circular dependencies check --- .github/workflows/static-root-checks.yml | 2 +- package.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/static-root-checks.yml b/.github/workflows/static-root-checks.yml index eda476ecb1..3eab273015 100644 --- a/.github/workflows/static-root-checks.yml +++ b/.github/workflows/static-root-checks.yml @@ -30,4 +30,4 @@ jobs: - name: Lint run: yarn lint:js-root - name: Check for circular dependencies - run: yarn circularDependencyCheck + run: yarn circular-dependency-check diff --git a/package.json b/package.json index 8349cb1d90..1f36eefa19 100644 --- a/package.json +++ b/package.json @@ -16,7 +16,7 @@ "lint:js-root": "eslint --ext '.js,.ts,.tsx' src/ && yarn prettier --check './src/**/*.{js,jsx,ts,tsx}'", "lint:android": "./android/gradlew -p android spotlessCheck -q", "check-integrity": "(cd ./FabricExample/android && ./gradlew generateCodegenArtifactsFromSchema -PskipCodegenCopyTask) && (cd ./android && ./gradlew checkIntegrityBetweenArchitectures)", - "circularDependencyCheck": "yarn madge --extensions js,ts,tsx --circular src" + "circular-dependency-check": "yarn madge --extensions js,ts,tsx --circular src" }, "react-native": "src/index.ts", "main": "lib/commonjs/index.js", From 62f47db51fdd0cf7ba1d626536216dcc95ec2fb8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ignacy=20=C5=81=C4=85tka?= Date: Tue, 2 Jul 2024 14:39:48 +0200 Subject: [PATCH 3/5] fix invalid usages of check-integrity --- .github/workflows/check-paper-integrity.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/check-paper-integrity.yml b/.github/workflows/check-paper-integrity.yml index f82e711bed..159d552111 100644 --- a/.github/workflows/check-paper-integrity.yml +++ b/.github/workflows/check-paper-integrity.yml @@ -43,6 +43,6 @@ jobs: android/build android/.gradle key: ${{ runner.os }}-kotlin-lint-gradle-${{ hashFiles('**/*.gradle*', '**/gradle-wrapper.properties', 'android/build.gradle') }} - + - name: Check old arch integrity - run: yarn checkIntegrity + run: yarn check-integrity From 8e78613982f8fd5aab124d07404ae5624bb4496d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ignacy=20=C5=81=C4=85tka?= Date: Tue, 2 Jul 2024 15:04:45 +0200 Subject: [PATCH 4/5] change naming scheme to follow convention --- .github/workflows/check-paper-integrity.yml | 2 +- package.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/check-paper-integrity.yml b/.github/workflows/check-paper-integrity.yml index 159d552111..13d8bd0b31 100644 --- a/.github/workflows/check-paper-integrity.yml +++ b/.github/workflows/check-paper-integrity.yml @@ -45,4 +45,4 @@ jobs: key: ${{ runner.os }}-kotlin-lint-gradle-${{ hashFiles('**/*.gradle*', '**/gradle-wrapper.properties', 'android/build.gradle') }} - name: Check old arch integrity - run: yarn check-integrity + run: yarn integrity-check diff --git a/package.json b/package.json index 1f36eefa19..ebf2f5ff2d 100644 --- a/package.json +++ b/package.json @@ -15,7 +15,7 @@ "lint:js": "eslint --ext '.js,.ts,.tsx' src/ example/src FabricExample/src MacOSExample/src && yarn prettier --check './{src,example,FabricExample,MacOSExample}/**/*.{js,jsx,ts,tsx}'", "lint:js-root": "eslint --ext '.js,.ts,.tsx' src/ && yarn prettier --check './src/**/*.{js,jsx,ts,tsx}'", "lint:android": "./android/gradlew -p android spotlessCheck -q", - "check-integrity": "(cd ./FabricExample/android && ./gradlew generateCodegenArtifactsFromSchema -PskipCodegenCopyTask) && (cd ./android && ./gradlew checkIntegrityBetweenArchitectures)", + "integrity-check": "(cd ./FabricExample/android && ./gradlew generateCodegenArtifactsFromSchema -PskipCodegenCopyTask) && (cd ./android && ./gradlew checkIntegrityBetweenArchitectures)", "circular-dependency-check": "yarn madge --extensions js,ts,tsx --circular src" }, "react-native": "src/index.ts", From d815fe305851e473d88ee24eb29642b5196f0b52 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ignacy=20=C5=81=C4=85tka?= Date: Wed, 3 Jul 2024 09:28:18 +0200 Subject: [PATCH 5/5] rename integrity-check to something less broad --- .github/workflows/check-paper-integrity.yml | 2 +- package.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/check-paper-integrity.yml b/.github/workflows/check-paper-integrity.yml index 13d8bd0b31..d37071e9ff 100644 --- a/.github/workflows/check-paper-integrity.yml +++ b/.github/workflows/check-paper-integrity.yml @@ -45,4 +45,4 @@ jobs: key: ${{ runner.os }}-kotlin-lint-gradle-${{ hashFiles('**/*.gradle*', '**/gradle-wrapper.properties', 'android/build.gradle') }} - name: Check old arch integrity - run: yarn integrity-check + run: yarn cross-arch-integrity-check diff --git a/package.json b/package.json index ebf2f5ff2d..4e4390d8df 100644 --- a/package.json +++ b/package.json @@ -15,7 +15,7 @@ "lint:js": "eslint --ext '.js,.ts,.tsx' src/ example/src FabricExample/src MacOSExample/src && yarn prettier --check './{src,example,FabricExample,MacOSExample}/**/*.{js,jsx,ts,tsx}'", "lint:js-root": "eslint --ext '.js,.ts,.tsx' src/ && yarn prettier --check './src/**/*.{js,jsx,ts,tsx}'", "lint:android": "./android/gradlew -p android spotlessCheck -q", - "integrity-check": "(cd ./FabricExample/android && ./gradlew generateCodegenArtifactsFromSchema -PskipCodegenCopyTask) && (cd ./android && ./gradlew checkIntegrityBetweenArchitectures)", + "cross-arch-integrity-check": "(cd ./FabricExample/android && ./gradlew generateCodegenArtifactsFromSchema -PskipCodegenCopyTask) && (cd ./android && ./gradlew checkIntegrityBetweenArchitectures)", "circular-dependency-check": "yarn madge --extensions js,ts,tsx --circular src" }, "react-native": "src/index.ts",