-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Web LA] Remove
existingTransform
(#6060)
## Summary A while ago I've noticed that layout animations on mobile throw warning if one tries to add animation into `View` that has `transform` property. Now, while working on #5277 I've decided to remove code responsible for applying existing transform on web. Here are the reasons why I believe it is good idea: 1. It unifies behavior with mobile platforms, which are main target of `reanimated`. 2. Some of `transforms` were not applied correctly and required additional calculations to be implemented (like `skew`). 3. Removing existing transforms means removing a lot of `ifs` and unnecessary code. ## Test plan Tested on example app on `LA` examples.
- Loading branch information
Showing
4 changed files
with
34 additions
and
196 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.