Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: [Test Environments] Entry mocks do not include ZoomIn #5674

Closed
angelo-hub opened this issue Feb 15, 2024 · 3 comments
Closed

BUG: [Test Environments] Entry mocks do not include ZoomIn #5674

angelo-hub opened this issue Feb 15, 2024 · 3 comments
Labels
Missing repro This issue need minimum repro scenario Platform: iOS This issue is specific to iOS

Comments

@angelo-hub
Copy link

angelo-hub commented Feb 15, 2024

Description

The entry mocks currently don't include the ZoomIn entry, creating issues with any snapshots that include them.

fix is pretty simple and i have in a patch file already of just adding ZoomIn as a mockable layout animation

+  'ZoomIn',
   'ZoomInRotate',
   'ZoomInLeft',
   'ZoomInRight',

Steps to reproduce

  1. create a component with a ZoomIn layout effect
  2. try to create a jest snapshot of component
  3. test will fail as it's undefined

Snack or a link to a repository

N/A

Reanimated version

3.7.0

React Native version

0.72

Platforms

iOS

JavaScript runtime

None

Workflow

None

Architecture

None

Build type

None

Device

None

Device model

No response

Acknowledgements

Yes

@github-actions github-actions bot added the Platform: iOS This issue is specific to iOS label Feb 15, 2024
@angelo-hub angelo-hub changed the title BUG: Entry mocks do not include ZoomIn BUG: [Test Environments] Entry mocks do not include ZoomIn Feb 15, 2024
@github-actions github-actions bot added the Missing repro This issue need minimum repro scenario label Feb 15, 2024
Copy link

Hey! 👋

The issue doesn't seem to contain a minimal reproduction.

Could you provide a snack or a link to a GitHub repository under your username that reproduces the problem?

@tomekzaw
Copy link
Member

Should be fixed with #5372.

@Latropos
Copy link
Contributor

The fix is merged: #5372 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Missing repro This issue need minimum repro scenario Platform: iOS This issue is specific to iOS
Projects
None yet
Development

No branches or pull requests

3 participants