Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web: AnimatedComponent raises a deprecation warning for findDOMNode in v3.12.0 #6072

Closed
MaxGraey opened this issue Jun 3, 2024 · 7 comments · Fixed by #6030
Closed

web: AnimatedComponent raises a deprecation warning for findDOMNode in v3.12.0 #6072

MaxGraey opened this issue Jun 3, 2024 · 7 comments · Fixed by #6030
Labels
Missing info The user didn't precise the problem enough Missing repro This issue need minimum repro scenario Platform: Web This issue is specific to web

Comments

@MaxGraey
Copy link

MaxGraey commented Jun 3, 2024

Description

With latest update, Expo project for web builds start to show error:

Warning: findDOMNode is deprecated and will be removed in the next major release. 
Instead, add a ref directly to the element you want to reference. 
Learn more about using refs safely here: https://reactjs.org/link/strict-mode-find-node
    at AnimatedComponent
    ...

Steps to reproduce

start expo for web (or eact-native + react-native-for-web) with dev mode enabled.

Snack or a link to a repository

Reanimated version

3.12.0

React Native version

0.74

Platforms

Web

JavaScript runtime

V8

Workflow

Expo Dev Client

Architecture

Fabric (New Architecture)

Build type

Debug app & dev bundle

Device

None

Device model

No response

Acknowledgements

Yes

@github-actions github-actions bot added Platform: Web This issue is specific to web Missing info The user didn't precise the problem enough labels Jun 3, 2024
Copy link

github-actions bot commented Jun 3, 2024

Hey! 👋

It looks like you've omitted a few important sections from the issue template.

Please complete Snack or a link to a repository section.

@github-actions github-actions bot added the Missing repro This issue need minimum repro scenario label Jun 3, 2024
Copy link

github-actions bot commented Jun 3, 2024

Hey! 👋

The issue doesn't seem to contain a minimal reproduction.

Could you provide a snack or a link to a GitHub repository under your username that reproduces the problem?

@MaxGraey
Copy link
Author

MaxGraey commented Jun 5, 2024

It looks like this was introduced in #5960
here: deb7825#diff-8ee19000960c96e45bf813296fe1bc00203d9b26bc18e8c7f7a4dae6ca9682d7R238

@szydlovsky
Copy link
Contributor

Hey @MaxGraey this finNodeHandle is not even needed on Web since the tags are used only for native platforms. The code is refactored in #6030 and it should fix the warning.

@km-tr
Copy link

km-tr commented Jun 27, 2024

@szydlovsky
I'm getting the same error in 3.12.1 as well. What do you think?

@szydlovsky
Copy link
Contributor

@km-tr Yeah, I interpreted our release notes wrongly 😄 The fix will be present in 3.13 version

@km-tr
Copy link

km-tr commented Jun 27, 2024

@szydlovsky
I understand. I'll wait for 3.13.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Missing info The user didn't precise the problem enough Missing repro This issue need minimum repro scenario Platform: Web This issue is specific to web
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants