Fix Hermes not available on iOS when use_frameworks enabled #3491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can confirm that the fix works. |
piaskowyk
pushed a commit
that referenced
this pull request
Oct 20, 2022
When there are frameworks used and Hermes enabled in the Podfile of your project, RN falls back to JSC in debug mode and crashes in production mode. This PR makes it possible to use Hermes when there is `use_frameworks!` enabled in the Podfile. Thanks @Kudo who originally fixed this issue in ReactNative repository: facebook/react-native#34222 Added path to `Framework Search Paths` in Podspec of react-native-reanimated. 1. Create empty ReactNative project 2. Add react-native-reanimated dependency. 3. For ReactNative 0.69.3 apply patch from: https://github.com/facebook/react-native/pull/34222/files 4. Enable frameworks in Podfile: `use_frameworks! :linkage => :static` 5. Build project in debug mode -> you will not see `engine: hermes` in top right corner. 6. Build project in release mode -> app will crash at startup - [ ] Included code example that can be used to test this change - [ ] Updated TS types - [ ] Added TS types tests - [ ] Added unit / integration tests - [ ] Updated documentation - [ ] Ensured that CI passes
fluiddot
pushed a commit
to wordpress-mobile/react-native-reanimated
that referenced
this pull request
Jun 5, 2023
…-mansion#3491) ## Description When there are frameworks used and Hermes enabled in the Podfile of your project, RN falls back to JSC in debug mode and crashes in production mode. This PR makes it possible to use Hermes when there is `use_frameworks!` enabled in the Podfile. Thanks @Kudo who originally fixed this issue in ReactNative repository: facebook/react-native#34222 ## Changes Added path to `Framework Search Paths` in Podspec of react-native-reanimated. ## Test code and steps to reproduce 1. Create empty ReactNative project 2. Add react-native-reanimated dependency. 3. For ReactNative 0.69.3 apply patch from: https://github.com/facebook/react-native/pull/34222/files 4. Enable frameworks in Podfile: `use_frameworks! :linkage => :static` 5. Build project in debug mode -> you will not see `engine: hermes` in top right corner. 6. Build project in release mode -> app will crash at startup ## Checklist - [ ] Included code example that can be used to test this change - [ ] Updated TS types - [ ] Added TS types tests - [ ] Added unit / integration tests - [ ] Updated documentation - [ ] Ensured that CI passes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When there are frameworks used and Hermes enabled in the Podfile of your project, RN falls back to JSC in debug mode and crashes in production mode.
This PR makes it possible to use Hermes when there is
use_frameworks!enabled in the Podfile.Thanks @Kudo who originally fixed this issue in ReactNative repository: facebook/react-native#34222
Changes
Added path to
Framework Search Pathsin Podspec of react-native-reanimated.Test code and steps to reproduce
use_frameworks! :linkage => :staticengine: hermesin top right corner.Checklist