From fbc9a005eafcd374f17164612347116ebcb4e268 Mon Sep 17 00:00:00 2001 From: Kacper Kafara Date: Wed, 8 Jan 2025 14:50:25 +0100 Subject: [PATCH] fix(Android): fix warning by removing package declaration from AndroidManifest (#2603) ## Description See the discussion: https://github.com/software-mansion/react-native-screens/discussions/2597#discussioncomment-11759520 ## Changes Removed the package declaration from Android Manifest. ## Test code and steps to reproduce Passing build should be enough. ## Checklist - [x] Ensured that CI passes --- android/build.gradle | 3 ++- android/src/main/AndroidManifest.xml | 3 +-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/android/build.gradle b/android/build.gradle index db1e03d3fe..444f4c9122 100644 --- a/android/build.gradle +++ b/android/build.gradle @@ -99,9 +99,10 @@ def IS_NEW_ARCHITECTURE_ENABLED = isNewArchitectureEnabled() android { compileSdkVersion safeExtGet('compileSdkVersion', rnsDefaultCompileSdkVersion) + namespace "com.swmansion.rnscreens" + def agpVersion = Version.ANDROID_GRADLE_PLUGIN_VERSION if (agpVersion.tokenize('.')[0].toInteger() >= 7) { - namespace "com.swmansion.rnscreens" buildFeatures { buildConfig true } diff --git a/android/src/main/AndroidManifest.xml b/android/src/main/AndroidManifest.xml index 2de74e803d..5f5d7a233b 100644 --- a/android/src/main/AndroidManifest.xml +++ b/android/src/main/AndroidManifest.xml @@ -1,5 +1,4 @@ - +