Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using native toasts from Burnt, FullWindowOverlay is hiding the whole content #1930

Closed
tboba opened this issue Oct 18, 2023 Discussed in #1907 · 4 comments
Closed

When using native toasts from Burnt, FullWindowOverlay is hiding the whole content #1930

tboba opened this issue Oct 18, 2023 Discussed in #1907 · 4 comments
Labels
Area: Native Stack Bug Something isn't working Missing info The user didn't precise the problem enough Missing repro This issue need minimum repro scenario Platform: iOS This issue is specific to iOS

Comments

@tboba
Copy link
Member

tboba commented Oct 18, 2023

Discussed in #1907

Originally posted by @wcastand September 29, 2023

Description

Trying to use Burnt but the native toasts are hidden behind my FullWindowOverlay component. i need it because it's a pin code security so need to go above all other window, modal included but not toasts x)

i have a screen inside a FullWindowOverlay that is used when the user comeback after X seconde to ask for a security pin code, since i need this screen as a security it's over everything in the app and i used FullWindowOverlay to achieve that.

when we tried to use burnt, the toast it creates is also hidden by the FullWindowOverlay screen, even if i call the toast inside the FullWindowOverlay component.

i'm no expert but from what i understood, burnt use the app root view as the parent for the toast but FullWindowOverlay create a view above the root to be above everything which means it's also above the toast.

Current hierachy (assuming FullScreenWindowOverlayContainer is a FullWindowOverlay and SPIndicatorView is a toast)

image
image
it's the view hierarchy when the toast is hidden behind the full window overlay (i called the toast inside the full window overlay component and it's hidden behind it still)

Steps to reproduce

Create a FullWindowOverlay and try to create a native toast from Burnt library. Native toast should be visible there, but it is not.

Screens version

3.25.0, but I would assume this occurs on every react-native-screens version.

React Native version

0.72.5

Platforms

iOS

JavaScript runtime

Hermes

Workflow

React Native (without Expo)

Architecture

Paper (Old Architecture)

Build type

Debug mode

Device

iOS simulator

Device model

iPhone 15 Pro Max (iOS 17.0)

Acknowledgements

Yes

@tboba tboba added Bug Something isn't working Area: Native Stack Platform: iOS This issue is specific to iOS labels Oct 18, 2023
@github-actions github-actions bot added the Missing repro This issue need minimum repro scenario label Oct 18, 2023
@github-actions
Copy link

Hey! 👋

The issue doesn't seem to contain a minimal reproduction.

Could you provide a snack or a link to a GitHub repository under your username that reproduces the problem?

@github-actions github-actions bot added the Missing info The user didn't precise the problem enough label Oct 18, 2023
@github-actions
Copy link

Hey! 👋

It looks like you've omitted a few important sections from the issue template.

Please complete Snack or a link to a repository section.

@karankalsi
Copy link

I can confirm that this issue is happening after opening a react-native Modal.

@kkafar
Copy link
Member

kkafar commented Jun 8, 2024

Hey, I do not consider it an issue on our side. FullWindowOverlay does exactly what it name suggests - it is presented above all content. Yes, indeed, it is mounted under dedicated UIWindow subview, but it is done on purpose, because in any other case it won't be able to be presented above modals. Hence I believe we won't be introducing changes in this matter on our side.

It might be worth changing the implementation of burnt library that you're using, so that it is presented above the FullWindowOverlay component.

Ping me if any new relevant information emerges.

@kkafar kkafar closed this as completed Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Native Stack Bug Something isn't working Missing info The user didn't precise the problem enough Missing repro This issue need minimum repro scenario Platform: iOS This issue is specific to iOS
Projects
None yet
Development

No branches or pull requests

3 participants