-
-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to build v3.26.0 on Android #1931
Comments
Hey! 👋 The issue doesn't seem to contain a minimal reproduction. Could you provide a snack or a link to a GitHub repository under your username that reproduces the problem? |
Same issue here, React Native 0.70.13 |
CI is passing & it works for me locally. W/o reproduction we can't do much. |
Unfortunately, our project is in a private repo so I can’t provide a link. I’ll try to create a minimum reproduction if I can find the time. |
Looking into my errors further, seems I'm getting a different error. This is from a production build which could be the reason for the different errors.
Hopefully this is helpful. My repo is also private so it cannot be shared. |
Looks like the Kotlin version was changed in v3.26.0 (see example). I had to update my Kotlin version to match the example, and add the diff --git a/android/build.gradle b/android/build.gradle
index acc9e057..86a99482 100644
--- a/android/build.gradle
+++ b/android/build.gradle
@@ -6,7 +6,7 @@ buildscript {
minSdkVersion = 21
compileSdkVersion = 33
targetSdkVersion = 33
- kotlinVersion = "1.6.21"
+ kotlinVersion = "1.8.22"
// We use NDK 23 which has both M1 support and is the side-by-side NDK version from AGP.
ndkVersion = "23.1.7779620"
@@ -18,6 +18,7 @@ buildscript {
dependencies {
classpath("com.android.tools.build:gradle")
classpath("com.facebook.react:react-native-gradle-plugin")
+ classpath("org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlinVersion")
classpath('com.google.gms:google-services:4.3.14')
classpath('com.google.firebase:firebase-crashlytics-gradle:2.2.0')
// NOTE: Do not place your application dependencies here; they belong After this, the Android build completed successfully. Note that this version of Kotlin is different than what is used in the v0.73.0 template, so this may be an issue once that release is final. |
@kkafar Thanks for taking a look! |
|
Why this kotlinVersion update is not a |
I can only cite myself
also:
|
@kkafar Is there any other solution without setting the |
You can stick to |
I've reproduced the issue finally -> I had bumped |
Hey @short-dsb @bhandanyan-nomad @eduardo-santos-tribia! Just wanna announce that we're released react-native-screens 3.27.0 which includes the fix for that issue! 🎉 Cheers! |
Opened new issue: |
Description
Release v3.25.0 works fine, but v3.26.0 fails to build for Android (iOS builds successfully).
Steps to reproduce
npm run react-native run-android
Snack or a link to a repository
N/A, build issue and private repo
Screens version
3.26.0
React Native version
0.72.6
Platforms
Android
JavaScript runtime
Hermes
Workflow
React Native (without Expo)
Architecture
Paper (Old Architecture)
Build type
Debug mode
Device
Android emulator
Device model
Pixel 6 Pro (API 32)
Acknowledgements
Yes
The text was updated successfully, but these errors were encountered: