[3.30.0] Installation fails after new release. /bin/sh: 1: cd: can't cd to react-navigation

[kuzkokov]

Description

Hey guys. Just got this error from the CI/CD that was working fine previously:

error /project/node_modules/react-native-screens: Command failed.
Exit code: 2
Command: git submodule update --init --recursive && (cd react-navigation && yarn)
Arguments: 
Directory: /project/node_modules/react-native-screens
Output:
/bin/sh: 1: cd: can't cd to react-navigation

I guess it's because of the newest release and this PR?
Didn't really made much research and reproducing, but it seems quite clear what this is about

Steps to reproduce

1. yarn install react-native-screens
2. enjoy

Snack or a link to a repository

N/A

Screens version

3.30.0

React Native version

0.73.6

Platforms

Android, iOS

JavaScript runtime

Hermes

Workflow

React Native (without Expo)

Architecture

Paper (Old Architecture)

Build type

None

Device

None

Device model

No response

Acknowledgements

Yes

[github-actions]

Hey! 👋

The issue doesn't seem to contain a minimal reproduction.

Could you provide a snack or a link to a GitHub repository under your username that reproduces the problem?

[donutdonate]

faced with the same issue

[tboba]

Hi @kuzkokov, @donutdonate - thanks for reporting this. Yeah, looks like we didn't cover .gitmodules file we've added recently 😓 We'll take care of this in upcoming days. For now, you can stay with the 3.29.0 version to build Screens on CI. If it's possible for you, please wait up to 15-30 minutes for the new patch release.
Thank you for your patience 🙏

[cubancodepath]

Same issues in React Native (without expo)

Step to reproduce

npm i react-native-screens

[efstathiosntonas]

same here on CI

➜  ~ cat  /private/var/folders/cm/2r_39vcd593436b3_ht4nyqw0000gp/T/xfs-56d7b1c0/build.log
# This file contains the result of Yarn building a package (react-native-screens@virtual:e76baedaa29db3684127472f1ffb54fc23b24818fe3b47237f9ea5a6c6226499143d9e7f52c3ec3524b3e879b25ce856756a7143b6b085990b2cef70a047c6d9#npm:3.30.0)
# Script name: postinstall

cd: no such file or directory: react-navigation

[tboba]

@efstathiosntonas @cubancodepath @kuzkokov @short-dsb @Alexandre-Cornillon @donutdonate @kuzkokov @akeva001 @Lump01

Could you please check whether the newest commit in 3.30.0 branch resolves the issue with builds and that your app works correctly while using the version from branch?

Please change in package.json version of react-native-screens to:

"react-native-screens": "software-mansion/react-native-screens#3.30.0"

[efstathiosntonas]

@tboba can't install with yarn 4.1.1 🤷 , it stucks here:

[4/4] Building fresh packages...
$ git submodule update --init --recursive && (cd react-navigation && yarn)
Submodule 'react-navigation' (https://github.com/react-navigation/react-navigation.git) registered for path 'react-navigation'
Cloning into '/private/var/folders/tc/sj1dwpmd3wx006fkwntygshh0000gn/T/xfs-815f8c19/react-navigation'...

offtopic: Why reanimated is pinned at 3.7.0-nightly-20240109-9e2c33716 on package.json? 🤔

[tboba]

@efstathiosntonas okay, let me quickly check this change with npm pack 🙏

About the offtopic - that's because this nightly has been made for the purposes of making goBackGesture work before the PR with implementing the functionalities on reanimated has been merged 😄

[Lump01]

@efstathiosntonas @cubancodepath @kuzkokov @short-dsb @Alexandre-Cornillon @donutdonate @kuzkokov @akeva001 @Lump01

Could you please check whether the newest commit in 3.30.0 branch resolves the issue with builds and that your app works correctly while using the version from branch?

Please change in package.json version of react-native-screens to:

"react-native-screens": "software-mansion/react-native-screens#3.30.0"

Still getting the issue with the submodule.

npm ERR! command sh -c git submodule update --init --recursive && (cd react-navigation && yarn)
npm ERR! npm ERR! fatal: not a git repository (or any of the parent directories): .git

Could it be that the pipeline failed for the branch of react-navigation y'all are pulling in as a submodule?

react-navigation 523fa4f

[tboba]

@Lump01 that's strange 🤔 but this is not caused from react-navigation for sure.

[tboba]

The patch has been released! Could you check whether this issue is fixed in 3.30.1?

cc @kuzkokov @donutdonate @short-dsb @Alexandre-Cornillon @akeva001 @Lump01 @efstathiosntonas @twokilohertz @cubancodepath @mohd-ramzan-1

[tboba]

cc @aditya063 @FraserKemp (I see you've also reacted to the issue)

[FraserKemp]

@tboba Just tested this now on 3.30.1 and it all seemed to work for me! Thanks for the speedy fix !

[tboba]

Great @FraserKemp, thanks for letting me know! I'll wait for the opinion from others before closing this issue. Can anyone also confirm this error doesn't happen anymore?

[Lump01]

I was able to install 3.30.1 successfully!

[Lump01]

Thanks for the speedy fix @tboba

[efstathiosntonas]

3.30.1 worked as a charm, thank you @tboba for the really quick fix.

[tboba]

That's great to hear! Now I can sleep well 😄 🚀
I'll assume this issue can be closed for now, but if anyone is still impacted of this error, feel free to comment your scenario below.

Cheers 🙏

[Alexandre-Cornillon]

3.30.1 worked nice for me too :) Big thanks 👍