diff --git a/ios/RNSConvert.h b/ios/RNSConvert.h index 1dca19797b..17b0485dc8 100644 --- a/ios/RNSConvert.h +++ b/ios/RNSConvert.h @@ -2,36 +2,34 @@ #import #import "RNSEnums.h" +namespace react = facebook::react; + @interface RNSConvert : NSObject + (RNSScreenStackPresentation)RNSScreenStackPresentationFromCppEquivalent: - (facebook::react::RNSScreenStackPresentation)stackPresentation; + (react::RNSScreenStackPresentation)stackPresentation; -+ (RNSScreenStackAnimation)RNSScreenStackAnimationFromCppEquivalent: - (facebook::react::RNSScreenStackAnimation)stackAnimation; ++ (RNSScreenStackAnimation)RNSScreenStackAnimationFromCppEquivalent:(react::RNSScreenStackAnimation)stackAnimation; + (RNSScreenStackHeaderSubviewType)RNSScreenStackHeaderSubviewTypeFromCppEquivalent: - (facebook::react::RNSScreenStackHeaderSubviewType)subviewType; + (react::RNSScreenStackHeaderSubviewType)subviewType; + (RNSScreenReplaceAnimation)RNSScreenReplaceAnimationFromCppEquivalent: - (facebook::react::RNSScreenReplaceAnimation)replaceAnimation; + (react::RNSScreenReplaceAnimation)replaceAnimation; -+ (RNSScreenSwipeDirection)RNSScreenSwipeDirectionFromCppEquivalent: - (facebook::react::RNSScreenSwipeDirection)swipeDirection; ++ (RNSScreenSwipeDirection)RNSScreenSwipeDirectionFromCppEquivalent:(react::RNSScreenSwipeDirection)swipeDirection; -+ (RNSScreenDetentType)RNSScreenDetentTypeFromAllowedDetents: - (facebook::react::RNSScreenSheetAllowedDetents)allowedDetents; ++ (RNSScreenDetentType)RNSScreenDetentTypeFromAllowedDetents:(react::RNSScreenSheetAllowedDetents)allowedDetents; -+ (RNSScreenDetentType)RNSScreenDetentTypeFromLargestUndimmedDetent: - (facebook::react::RNSScreenSheetLargestUndimmedDetent)detent; ++ (RNSScreenDetentType)RNSScreenDetentTypeFromLargestUndimmedDetent:(react::RNSScreenSheetLargestUndimmedDetent)detent; + (NSDictionary *)gestureResponseDistanceDictFromCppStruct: - (const facebook::react::RNSScreenGestureResponseDistanceStruct &)gestureResponseDistance; + (const react::RNSScreenGestureResponseDistanceStruct &)gestureResponseDistance; + (UITextAutocapitalizationType)UITextAutocapitalizationTypeFromCppEquivalent: - (facebook::react::RNSSearchBarAutoCapitalize)autoCapitalize; + (react::RNSSearchBarAutoCapitalize)autoCapitalize; -+ (RNSSearchBarPlacement)RNSScreenSearchBarPlacementFromCppEquivalent:(facebook::react::RNSSearchBarPlacement)placement; ++ (RNSSearchBarPlacement)RNSScreenSearchBarPlacementFromCppEquivalent:(react::RNSSearchBarPlacement)placement; @end diff --git a/ios/RNSConvert.mm b/ios/RNSConvert.mm index 818ecd366a..655d8fba43 100644 --- a/ios/RNSConvert.mm +++ b/ios/RNSConvert.mm @@ -4,119 +4,115 @@ @implementation RNSConvert + (RNSScreenStackPresentation)RNSScreenStackPresentationFromCppEquivalent: - (facebook::react::RNSScreenStackPresentation)stackPresentation + (react::RNSScreenStackPresentation)stackPresentation { switch (stackPresentation) { - case facebook::react::RNSScreenStackPresentation::Push: + case react::RNSScreenStackPresentation::Push: return RNSScreenStackPresentationPush; - case facebook::react::RNSScreenStackPresentation::Modal: + case react::RNSScreenStackPresentation::Modal: return RNSScreenStackPresentationModal; - case facebook::react::RNSScreenStackPresentation::FullScreenModal: + case react::RNSScreenStackPresentation::FullScreenModal: return RNSScreenStackPresentationFullScreenModal; - case facebook::react::RNSScreenStackPresentation::FormSheet: + case react::RNSScreenStackPresentation::FormSheet: return RNSScreenStackPresentationFormSheet; - case facebook::react::RNSScreenStackPresentation::ContainedModal: + case react::RNSScreenStackPresentation::ContainedModal: return RNSScreenStackPresentationContainedModal; - case facebook::react::RNSScreenStackPresentation::TransparentModal: + case react::RNSScreenStackPresentation::TransparentModal: return RNSScreenStackPresentationTransparentModal; - case facebook::react::RNSScreenStackPresentation::ContainedTransparentModal: + case react::RNSScreenStackPresentation::ContainedTransparentModal: return RNSScreenStackPresentationContainedTransparentModal; } } -+ (RNSScreenStackAnimation)RNSScreenStackAnimationFromCppEquivalent: - (facebook::react::RNSScreenStackAnimation)stackAnimation ++ (RNSScreenStackAnimation)RNSScreenStackAnimationFromCppEquivalent:(react::RNSScreenStackAnimation)stackAnimation { switch (stackAnimation) { // these three are intentionally grouped - case facebook::react::RNSScreenStackAnimation::Slide_from_right: - case facebook::react::RNSScreenStackAnimation::Slide_from_left: - case facebook::react::RNSScreenStackAnimation::Default: + case react::RNSScreenStackAnimation::Slide_from_right: + case react::RNSScreenStackAnimation::Slide_from_left: + case react::RNSScreenStackAnimation::Default: return RNSScreenStackAnimationDefault; - case facebook::react::RNSScreenStackAnimation::Flip: + case react::RNSScreenStackAnimation::Flip: return RNSScreenStackAnimationFlip; - case facebook::react::RNSScreenStackAnimation::Simple_push: + case react::RNSScreenStackAnimation::Simple_push: return RNSScreenStackAnimationSimplePush; - case facebook::react::RNSScreenStackAnimation::None: + case react::RNSScreenStackAnimation::None: return RNSScreenStackAnimationNone; - case facebook::react::RNSScreenStackAnimation::Fade: + case react::RNSScreenStackAnimation::Fade: return RNSScreenStackAnimationFade; - case facebook::react::RNSScreenStackAnimation::Slide_from_bottom: + case react::RNSScreenStackAnimation::Slide_from_bottom: return RNSScreenStackAnimationSlideFromBottom; - case facebook::react::RNSScreenStackAnimation::Fade_from_bottom: + case react::RNSScreenStackAnimation::Fade_from_bottom: return RNSScreenStackAnimationFadeFromBottom; } } + (RNSScreenStackHeaderSubviewType)RNSScreenStackHeaderSubviewTypeFromCppEquivalent: - (facebook::react::RNSScreenStackHeaderSubviewType)subviewType + (react::RNSScreenStackHeaderSubviewType)subviewType { switch (subviewType) { - case facebook::react::RNSScreenStackHeaderSubviewType::Left: + case react::RNSScreenStackHeaderSubviewType::Left: return RNSScreenStackHeaderSubviewTypeLeft; - case facebook::react::RNSScreenStackHeaderSubviewType::Right: + case react::RNSScreenStackHeaderSubviewType::Right: return RNSScreenStackHeaderSubviewTypeRight; - case facebook::react::RNSScreenStackHeaderSubviewType::Title: + case react::RNSScreenStackHeaderSubviewType::Title: return RNSScreenStackHeaderSubviewTypeTitle; - case facebook::react::RNSScreenStackHeaderSubviewType::Center: + case react::RNSScreenStackHeaderSubviewType::Center: return RNSScreenStackHeaderSubviewTypeCenter; - case facebook::react::RNSScreenStackHeaderSubviewType::SearchBar: + case react::RNSScreenStackHeaderSubviewType::SearchBar: return RNSScreenStackHeaderSubviewTypeSearchBar; - case facebook::react::RNSScreenStackHeaderSubviewType::Back: + case react::RNSScreenStackHeaderSubviewType::Back: return RNSScreenStackHeaderSubviewTypeBackButton; } } + (RNSScreenReplaceAnimation)RNSScreenReplaceAnimationFromCppEquivalent: - (facebook::react::RNSScreenReplaceAnimation)replaceAnimation + (react::RNSScreenReplaceAnimation)replaceAnimation { switch (replaceAnimation) { - case facebook::react::RNSScreenReplaceAnimation::Pop: + case react::RNSScreenReplaceAnimation::Pop: return RNSScreenReplaceAnimationPop; - case facebook::react::RNSScreenReplaceAnimation::Push: + case react::RNSScreenReplaceAnimation::Push: return RNSScreenReplaceAnimationPush; } } -+ (RNSScreenSwipeDirection)RNSScreenSwipeDirectionFromCppEquivalent: - (facebook::react::RNSScreenSwipeDirection)swipeDirection ++ (RNSScreenSwipeDirection)RNSScreenSwipeDirectionFromCppEquivalent:(react::RNSScreenSwipeDirection)swipeDirection { switch (swipeDirection) { - case facebook::react::RNSScreenSwipeDirection::Horizontal: + case react::RNSScreenSwipeDirection::Horizontal: return RNSScreenSwipeDirectionHorizontal; - case facebook::react::RNSScreenSwipeDirection::Vertical: + case react::RNSScreenSwipeDirection::Vertical: return RNSScreenSwipeDirectionVertical; } } -+ (RNSScreenDetentType)RNSScreenDetentTypeFromAllowedDetents: - (facebook::react::RNSScreenSheetAllowedDetents)allowedDetents ++ (RNSScreenDetentType)RNSScreenDetentTypeFromAllowedDetents:(react::RNSScreenSheetAllowedDetents)allowedDetents { switch (allowedDetents) { - case facebook::react::RNSScreenSheetAllowedDetents::All: + case react::RNSScreenSheetAllowedDetents::All: return RNSScreenDetentTypeAll; - case facebook::react::RNSScreenSheetAllowedDetents::Large: + case react::RNSScreenSheetAllowedDetents::Large: return RNSScreenDetentTypeLarge; - case facebook::react::RNSScreenSheetAllowedDetents::Medium: + case react::RNSScreenSheetAllowedDetents::Medium: return RNSScreenDetentTypeMedium; } } -+ (RNSScreenDetentType)RNSScreenDetentTypeFromLargestUndimmedDetent: - (facebook::react::RNSScreenSheetLargestUndimmedDetent)detent ++ (RNSScreenDetentType)RNSScreenDetentTypeFromLargestUndimmedDetent:(react::RNSScreenSheetLargestUndimmedDetent)detent { switch (detent) { - case facebook::react::RNSScreenSheetLargestUndimmedDetent::All: + case react::RNSScreenSheetLargestUndimmedDetent::All: return RNSScreenDetentTypeAll; - case facebook::react::RNSScreenSheetLargestUndimmedDetent::Large: + case react::RNSScreenSheetLargestUndimmedDetent::Large: return RNSScreenDetentTypeLarge; - case facebook::react::RNSScreenSheetLargestUndimmedDetent::Medium: + case react::RNSScreenSheetLargestUndimmedDetent::Medium: return RNSScreenDetentTypeMedium; } } + (NSDictionary *)gestureResponseDistanceDictFromCppStruct: - (const facebook::react::RNSScreenGestureResponseDistanceStruct &)gestureResponseDistance + (const react::RNSScreenGestureResponseDistanceStruct &)gestureResponseDistance { return @{ @"start" : @(gestureResponseDistance.start), @@ -127,28 +123,28 @@ + (NSDictionary *)gestureResponseDistanceDictFromCppStruct: } + (UITextAutocapitalizationType)UITextAutocapitalizationTypeFromCppEquivalent: - (facebook::react::RNSSearchBarAutoCapitalize)autoCapitalize + (react::RNSSearchBarAutoCapitalize)autoCapitalize { switch (autoCapitalize) { - case facebook::react::RNSSearchBarAutoCapitalize::Words: + case react::RNSSearchBarAutoCapitalize::Words: return UITextAutocapitalizationTypeWords; - case facebook::react::RNSSearchBarAutoCapitalize::Sentences: + case react::RNSSearchBarAutoCapitalize::Sentences: return UITextAutocapitalizationTypeSentences; - case facebook::react::RNSSearchBarAutoCapitalize::Characters: + case react::RNSSearchBarAutoCapitalize::Characters: return UITextAutocapitalizationTypeAllCharacters; - case facebook::react::RNSSearchBarAutoCapitalize::None: + case react::RNSSearchBarAutoCapitalize::None: return UITextAutocapitalizationTypeNone; } } -+ (RNSSearchBarPlacement)RNSScreenSearchBarPlacementFromCppEquivalent:(facebook::react::RNSSearchBarPlacement)placement ++ (RNSSearchBarPlacement)RNSScreenSearchBarPlacementFromCppEquivalent:(react::RNSSearchBarPlacement)placement { switch (placement) { - case facebook::react::RNSSearchBarPlacement::Stacked: + case react::RNSSearchBarPlacement::Stacked: return RNSSearchBarPlacementStacked; - case facebook::react::RNSSearchBarPlacement::Automatic: + case react::RNSSearchBarPlacement::Automatic: return RNSSearchBarPlacementAutomatic; - case facebook::react::RNSSearchBarPlacement::Inline: + case react::RNSSearchBarPlacement::Inline: return RNSSearchBarPlacementInline; } } diff --git a/ios/RNSFullWindowOverlay.h b/ios/RNSFullWindowOverlay.h index 3f756643a2..65d6100117 100644 --- a/ios/RNSFullWindowOverlay.h +++ b/ios/RNSFullWindowOverlay.h @@ -7,6 +7,10 @@ #import #endif +#ifdef RCT_NEW_ARCH_ENABLED +namespace react = facebook::react; +#endif // RCT_NEW_ARCH_ENABLED + @interface RNSFullWindowOverlayManager : RCTViewManager @end @@ -23,8 +27,8 @@ #endif // RCT_NEW_ARCH_ENABLED #ifdef RCT_NEW_ARCH_ENABLED -@property (nonatomic) facebook::react::LayoutMetrics oldLayoutMetrics; -@property (nonatomic) facebook::react::LayoutMetrics newLayoutMetrics; +@property (nonatomic) react::LayoutMetrics oldLayoutMetrics; +@property (nonatomic) react::LayoutMetrics newLayoutMetrics; #endif // RCT_NEW_ARCH_ENABLED @end diff --git a/ios/RNSFullWindowOverlay.mm b/ios/RNSFullWindowOverlay.mm index 841bf11180..101cacecf8 100644 --- a/ios/RNSFullWindowOverlay.mm +++ b/ios/RNSFullWindowOverlay.mm @@ -82,7 +82,7 @@ @implementation RNSFullWindowOverlay { - (instancetype)init { if (self = [super init]) { - static const auto defaultProps = std::make_shared(); + static const auto defaultProps = std::make_shared(); _props = defaultProps; [self _initCommon]; } @@ -162,10 +162,9 @@ - (void)maybeShow } } -+ (facebook::react::ComponentDescriptorProvider)componentDescriptorProvider ++ (react::ComponentDescriptorProvider)componentDescriptorProvider { - return facebook::react::concreteComponentDescriptorProvider< - facebook::react::RNSFullWindowOverlayComponentDescriptor>(); + return react::concreteComponentDescriptorProvider(); } - (void)prepareForRecycle @@ -193,8 +192,8 @@ - (void)unmountChildComponentView:(UIView *)childCompo [childComponentView removeFromSuperview]; } -- (void)updateLayoutMetrics:(facebook::react::LayoutMetrics const &)layoutMetrics - oldLayoutMetrics:(facebook::react::LayoutMetrics const &)oldLayoutMetrics +- (void)updateLayoutMetrics:(react::LayoutMetrics const &)layoutMetrics + oldLayoutMetrics:(react::LayoutMetrics const &)oldLayoutMetrics { CGRect frame = RCTCGRectFromRect(layoutMetrics.frame); _reactFrame = frame; diff --git a/ios/RNSScreen.h b/ios/RNSScreen.h index 9179699d68..3583ddedb6 100644 --- a/ios/RNSScreen.h +++ b/ios/RNSScreen.h @@ -8,10 +8,14 @@ #import #else #import -#endif +#endif // RCT_NEW_ARCH_ENABLED NS_ASSUME_NONNULL_BEGIN +#ifdef RCT_NEW_ARCH_ENABLED +namespace react = facebook::react; +#endif // RCT_NEW_ARCH_ENABLED + @interface RCTConvert (RNSScreen) + (RNSScreenStackPresentation)RNSScreenStackPresentation:(id)json; @@ -88,8 +92,8 @@ NS_ASSUME_NONNULL_BEGIN #ifdef RCT_NEW_ARCH_ENABLED // we recreate the behavior of `reactSetFrame` on new architecture -@property (nonatomic) facebook::react::LayoutMetrics oldLayoutMetrics; -@property (nonatomic) facebook::react::LayoutMetrics newLayoutMetrics; +@property (nonatomic) react::LayoutMetrics oldLayoutMetrics; +@property (nonatomic) react::LayoutMetrics newLayoutMetrics; @property (weak, nonatomic) RNSScreenStackHeaderConfig *config; @property (nonatomic, readonly) BOOL hasHeaderConfig; #else diff --git a/ios/RNSScreen.mm b/ios/RNSScreen.mm index 5dd618f1eb..b2608acd06 100644 --- a/ios/RNSScreen.mm +++ b/ios/RNSScreen.mm @@ -24,6 +24,10 @@ #import "RNSScreenStack.h" #import "RNSScreenStackHeaderConfig.h" +#ifdef RCT_NEW_ARCH_ENABLED +namespace react = facebook::react; +#endif // RCT_NEW_ARCH_ENABLED + @interface RNSScreenView () #ifdef RCT_NEW_ARCH_ENABLED @@ -36,7 +40,7 @@ @implementation RNSScreenView { __weak RCTBridge *_bridge; #ifdef RCT_NEW_ARCH_ENABLED RCTSurfaceTouchHandler *_touchHandler; - facebook::react::RNSScreenShadowNode::ConcreteState::Shared _state; + react::RNSScreenShadowNode::ConcreteState::Shared _state; // on fabric, they are not available by default so we need them exposed here too NSMutableArray *_reactSubviews; #else @@ -49,7 +53,7 @@ @implementation RNSScreenView { - (instancetype)initWithFrame:(CGRect)frame { if (self = [super initWithFrame:frame]) { - static const auto defaultProps = std::make_shared(); + static const auto defaultProps = std::make_shared(); _props = defaultProps; _reactSubviews = [NSMutableArray new]; [self initCommonProps]; @@ -102,7 +106,7 @@ - (void)updateBounds { #ifdef RCT_NEW_ARCH_ENABLED if (_state != nullptr) { - auto newState = facebook::react::RNSScreenState{RCTSizeFromCGSize(self.bounds.size)}; + auto newState = react::RNSScreenState{RCTSizeFromCGSize(self.bounds.size)}; _state->updateState(std::move(newState)); UINavigationController *navctr = _controller.navigationController; [navctr.view setNeedsLayout]; @@ -283,8 +287,8 @@ - (void)notifyDismissedWithCount:(int)dismissCount // If screen is already unmounted then there will be no event emitter // it will be cleaned in prepareForRecycle if (_eventEmitter != nullptr) { - std::dynamic_pointer_cast(_eventEmitter) - ->onDismissed(facebook::react::RNSScreenEventEmitter::OnDismissed{.dismissCount = dismissCount}); + std::dynamic_pointer_cast(_eventEmitter) + ->onDismissed(react::RNSScreenEventEmitter::OnDismissed{.dismissCount = dismissCount}); } #else // TODO: hopefully problems connected to dismissed prop are only the case on paper @@ -305,9 +309,9 @@ - (void)notifyDismissCancelledWithDismissCount:(int)dismissCount // If screen is already unmounted then there will be no event emitter // it will be cleaned in prepareForRecycle if (_eventEmitter != nullptr) { - std::dynamic_pointer_cast(_eventEmitter) + std::dynamic_pointer_cast(_eventEmitter) ->onNativeDismissCancelled( - facebook::react::RNSScreenEventEmitter::OnNativeDismissCancelled{.dismissCount = dismissCount}); + react::RNSScreenEventEmitter::OnNativeDismissCancelled{.dismissCount = dismissCount}); } #else if (self.onNativeDismissCancelled) { @@ -322,8 +326,8 @@ - (void)notifyWillAppear // If screen is already unmounted then there will be no event emitter // it will be cleaned in prepareForRecycle if (_eventEmitter != nullptr) { - std::dynamic_pointer_cast(_eventEmitter) - ->onWillAppear(facebook::react::RNSScreenEventEmitter::OnWillAppear{}); + std::dynamic_pointer_cast(_eventEmitter) + ->onWillAppear(react::RNSScreenEventEmitter::OnWillAppear{}); } [self updateLayoutMetrics:_newLayoutMetrics oldLayoutMetrics:_oldLayoutMetrics]; #else @@ -345,8 +349,8 @@ - (void)notifyWillDisappear // If screen is already unmounted then there will be no event emitter // it will be cleaned in prepareForRecycle if (_eventEmitter != nullptr) { - std::dynamic_pointer_cast(_eventEmitter) - ->onWillDisappear(facebook::react::RNSScreenEventEmitter::OnWillDisappear{}); + std::dynamic_pointer_cast(_eventEmitter) + ->onWillDisappear(react::RNSScreenEventEmitter::OnWillDisappear{}); } #else if (self.onWillDisappear) { @@ -361,8 +365,8 @@ - (void)notifyAppear // If screen is already unmounted then there will be no event emitter // it will be cleaned in prepareForRecycle if (_eventEmitter != nullptr) { - std::dynamic_pointer_cast(_eventEmitter) - ->onAppear(facebook::react::RNSScreenEventEmitter::OnAppear{}); + std::dynamic_pointer_cast(_eventEmitter) + ->onAppear(react::RNSScreenEventEmitter::OnAppear{}); } #else if (self.onAppear) { @@ -381,8 +385,8 @@ - (void)notifyDisappear // If screen is already unmounted then there will be no event emitter // it will be cleaned in prepareForRecycle if (_eventEmitter != nullptr) { - std::dynamic_pointer_cast(_eventEmitter) - ->onDisappear(facebook::react::RNSScreenEventEmitter::OnDisappear{}); + std::dynamic_pointer_cast(_eventEmitter) + ->onDisappear(react::RNSScreenEventEmitter::OnDisappear{}); } #else if (self.onDisappear) { @@ -395,8 +399,8 @@ - (void)notifyGestureCancel { #ifdef RCT_NEW_ARCH_ENABLED if (_eventEmitter != nullptr) { - std::dynamic_pointer_cast(_eventEmitter) - ->onGestureCancel(facebook::react::RNSScreenEventEmitter::OnGestureCancel{}); + std::dynamic_pointer_cast(_eventEmitter) + ->onGestureCancel(react::RNSScreenEventEmitter::OnGestureCancel{}); } #else if (self.onGestureCancel) { @@ -467,8 +471,8 @@ - (void)notifyTransitionProgress:(double)progress closing:(BOOL)closing goingFor { #ifdef RCT_NEW_ARCH_ENABLED if (_eventEmitter != nullptr) { - std::dynamic_pointer_cast(_eventEmitter) - ->onTransitionProgress(facebook::react::RNSScreenEventEmitter::OnTransitionProgress{ + std::dynamic_pointer_cast(_eventEmitter) + ->onTransitionProgress(react::RNSScreenEventEmitter::OnTransitionProgress{ .progress = progress, .closing = closing ? 1 : 0, .goingForward = goingForward ? 1 : 0}); } RNSScreenViewEvent *event = [[RNSScreenViewEvent alloc] initWithEventName:@"onTransitionProgress" @@ -602,9 +606,9 @@ - (BOOL)hasHeaderConfig return _config != nil; } -+ (facebook::react::ComponentDescriptorProvider)componentDescriptorProvider ++ (react::ComponentDescriptorProvider)componentDescriptorProvider { - return facebook::react::concreteComponentDescriptorProvider(); + return react::concreteComponentDescriptorProvider(); } - (void)mountChildComponentView:(UIView *)childComponentView index:(NSInteger)index @@ -649,11 +653,10 @@ - (void)prepareForRecycle _stackPresentation = RNSScreenStackPresentationPush; } -- (void)updateProps:(facebook::react::Props::Shared const &)props - oldProps:(facebook::react::Props::Shared const &)oldProps +- (void)updateProps:(react::Props::Shared const &)props oldProps:(react::Props::Shared const &)oldProps { - const auto &oldScreenProps = *std::static_pointer_cast(_props); - const auto &newScreenProps = *std::static_pointer_cast(props); + const auto &oldScreenProps = *std::static_pointer_cast(_props); + const auto &newScreenProps = *std::static_pointer_cast(props); [self setFullScreenSwipeEnabled:newScreenProps.fullScreenSwipeEnabled]; @@ -732,14 +735,13 @@ - (void)updateProps:(facebook::react::Props::Shared const &)props [super updateProps:props oldProps:oldProps]; } -- (void)updateState:(facebook::react::State::Shared const &)state - oldState:(facebook::react::State::Shared const &)oldState +- (void)updateState:(react::State::Shared const &)state oldState:(react::State::Shared const &)oldState { - _state = std::static_pointer_cast(state); + _state = std::static_pointer_cast(state); } -- (void)updateLayoutMetrics:(const facebook::react::LayoutMetrics &)layoutMetrics - oldLayoutMetrics:(const facebook::react::LayoutMetrics &)oldLayoutMetrics +- (void)updateLayoutMetrics:(const react::LayoutMetrics &)layoutMetrics + oldLayoutMetrics:(const react::LayoutMetrics &)oldLayoutMetrics { _newLayoutMetrics = layoutMetrics; _oldLayoutMetrics = oldLayoutMetrics; diff --git a/ios/RNSScreenContainer.mm b/ios/RNSScreenContainer.mm index f7bd2a4bf1..09f5d4d4f5 100644 --- a/ios/RNSScreenContainer.mm +++ b/ios/RNSScreenContainer.mm @@ -6,7 +6,10 @@ #import #import #import -#endif + +namespace react = facebook::react; + +#endif // RCT_NEW_ARCH_ENABLED @implementation RNSViewController @@ -59,7 +62,7 @@ - (instancetype)init { if (self = [super init]) { #ifdef RCT_NEW_ARCH_ENABLED - static const auto defaultProps = std::make_shared(); + static const auto defaultProps = std::make_shared(); _props = defaultProps; #endif _activeScreens = [NSMutableSet new]; @@ -235,7 +238,7 @@ - (void)layoutSubviews _controller.view.frame = self.bounds; for (RNSScreenView *subview in _reactSubviews) { #ifdef RCT_NEW_ARCH_ENABLED - facebook::react::LayoutMetrics screenLayoutMetrics = subview.newLayoutMetrics; + react::LayoutMetrics screenLayoutMetrics = subview.newLayoutMetrics; screenLayoutMetrics.frame = RCTRectFromCGRect(CGRectMake(0, 0, self.bounds.size.width, self.bounds.size.height)); [subview updateLayoutMetrics:screenLayoutMetrics oldLayoutMetrics:subview.oldLayoutMetrics]; #else @@ -267,7 +270,7 @@ - (void)mountChildComponentView:(UIView *)childCompone [_reactSubviews insertObject:screenView atIndex:index]; screenView.reactSuperview = self; - facebook::react::LayoutMetrics screenLayoutMetrics = screenView.newLayoutMetrics; + react::LayoutMetrics screenLayoutMetrics = screenView.newLayoutMetrics; screenLayoutMetrics.frame = RCTRectFromCGRect(CGRectMake(0, 0, self.bounds.size.width, self.bounds.size.height)); [screenView updateLayoutMetrics:screenLayoutMetrics oldLayoutMetrics:screenView.oldLayoutMetrics]; [self markChildUpdated]; @@ -295,9 +298,9 @@ - (void)unmountChildComponentView:(UIView *)childCompo [self markChildUpdated]; } -+ (facebook::react::ComponentDescriptorProvider)componentDescriptorProvider ++ (react::ComponentDescriptorProvider)componentDescriptorProvider { - return facebook::react::concreteComponentDescriptorProvider(); + return react::concreteComponentDescriptorProvider(); } - (void)prepareForRecycle diff --git a/ios/RNSScreenNavigationContainer.mm b/ios/RNSScreenNavigationContainer.mm index e7160ea6be..f10671e230 100644 --- a/ios/RNSScreenNavigationContainer.mm +++ b/ios/RNSScreenNavigationContainer.mm @@ -6,7 +6,9 @@ #import #import #import -#endif + +namespace react = facebook::react; +#endif // RCT_NEW_ARCH_ENABLED @implementation RNSContainerNavigationController @@ -37,10 +39,9 @@ - (void)updateContainer #pragma mark-- Fabric specific #ifdef RCT_NEW_ARCH_ENABLED -+ (facebook::react::ComponentDescriptorProvider)componentDescriptorProvider ++ (react::ComponentDescriptorProvider)componentDescriptorProvider { - return facebook::react::concreteComponentDescriptorProvider< - facebook::react::RNSScreenNavigationContainerComponentDescriptor>(); + return react::concreteComponentDescriptorProvider(); } #endif diff --git a/ios/RNSScreenStack.mm b/ios/RNSScreenStack.mm index 271e5ffda9..b06ffbd9c7 100644 --- a/ios/RNSScreenStack.mm +++ b/ios/RNSScreenStack.mm @@ -22,6 +22,10 @@ #import "RNSScreenStackHeaderConfig.h" #import "RNSScreenWindowTraits.h" +#ifdef RCT_NEW_ARCH_ENABLED +namespace react = facebook::react; +#endif // RCT_NEW_ARCH_ENABLED + @interface RNSScreenStackView () < UINavigationControllerDelegate, UIAdaptivePresentationControllerDelegate, @@ -102,7 +106,7 @@ @implementation RNSScreenStackView { - (instancetype)initWithFrame:(CGRect)frame { if (self = [super initWithFrame:frame]) { - static const auto defaultProps = std::make_shared(); + static const auto defaultProps = std::make_shared(); _props = defaultProps; [self initCommonProps]; } @@ -159,8 +163,8 @@ - (void)emitOnFinishTransitioningEvent { #ifdef RCT_NEW_ARCH_ENABLED if (_eventEmitter != nullptr) { - std::dynamic_pointer_cast(_eventEmitter) - ->onFinishTransitioning(facebook::react::RNSScreenStackEventEmitter::OnFinishTransitioning{}); + std::dynamic_pointer_cast(_eventEmitter) + ->onFinishTransitioning(react::RNSScreenStackEventEmitter::OnFinishTransitioning{}); } #else if (self.onFinishTransitioning) { @@ -1003,12 +1007,11 @@ - (void)takeSnapshot _snapshot = [_controller.visibleViewController.view snapshotViewAfterScreenUpdates:NO]; } -- (void)mountingTransactionWillMount:(facebook::react::MountingTransaction const &)transaction - withSurfaceTelemetry:(facebook::react::SurfaceTelemetry const &)surfaceTelemetry +- (void)mountingTransactionWillMount:(react::MountingTransaction const &)transaction + withSurfaceTelemetry:(react::SurfaceTelemetry const &)surfaceTelemetry { for (auto &mutation : transaction.getMutations()) { - if (mutation.type == facebook::react::ShadowViewMutation::Type::Remove && - mutation.parentShadowView.componentName != nil && + if (mutation.type == react::ShadowViewMutation::Type::Remove && mutation.parentShadowView.componentName != nil && strcmp(mutation.parentShadowView.componentName, "RNSScreenStack") == 0) { [self takeSnapshot]; return; @@ -1032,9 +1035,9 @@ - (void)prepareForRecycle [_controller setViewControllers:@[ [UIViewController new] ]]; } -+ (facebook::react::ComponentDescriptorProvider)componentDescriptorProvider ++ (react::ComponentDescriptorProvider)componentDescriptorProvider { - return facebook::react::concreteComponentDescriptorProvider(); + return react::concreteComponentDescriptorProvider(); } #else #pragma mark - Paper specific diff --git a/ios/RNSScreenStackHeaderConfig.mm b/ios/RNSScreenStackHeaderConfig.mm index 33ec2f06cf..de0d910f5b 100644 --- a/ios/RNSScreenStackHeaderConfig.mm +++ b/ios/RNSScreenStackHeaderConfig.mm @@ -25,7 +25,7 @@ #import "RNSUIBarButtonItem.h" #ifdef RCT_NEW_ARCH_ENABLED -namespace rct = facebook::react; +namespace react = facebook::react; #endif // RCT_NEW_ARCH_ENABLED #ifndef RCT_NEW_ARCH_ENABLED @@ -64,7 +64,7 @@ @implementation RNSScreenStackHeaderConfig { - (instancetype)initWithFrame:(CGRect)frame { if (self = [super initWithFrame:frame]) { - static const auto defaultProps = std::make_shared(); + static const auto defaultProps = std::make_shared(); _props = defaultProps; _show = YES; _translucent = NO; @@ -315,7 +315,7 @@ + (UIImage *)loadBackButtonImageInViewController:(UIViewController *)vc withConf scale:imageSource.scale #ifdef RCT_NEW_ARCH_ENABLED resizeMode:resizeModeFromCppEquiv( - std::static_pointer_cast(imageView.props)->resizeMode)]; + std::static_pointer_cast(imageView.props)->resizeMode)]; #else resizeMode:imageView.resizeMode]; #endif // RCT_NEW_ARCH_ENABLED @@ -704,18 +704,18 @@ - (void)unmountChildComponentView:(UIView *)childCompo [childComponentView removeFromSuperview]; } -static RCTResizeMode resizeModeFromCppEquiv(rct::ImageResizeMode resizeMode) +static RCTResizeMode resizeModeFromCppEquiv(react::ImageResizeMode resizeMode) { switch (resizeMode) { - case rct::ImageResizeMode::Cover: + case react::ImageResizeMode::Cover: return RCTResizeModeCover; - case rct::ImageResizeMode::Contain: + case react::ImageResizeMode::Contain: return RCTResizeModeContain; - case rct::ImageResizeMode::Stretch: + case react::ImageResizeMode::Stretch: return RCTResizeModeStretch; - case rct::ImageResizeMode::Center: + case react::ImageResizeMode::Center: return RCTResizeModeCenter; - case rct::ImageResizeMode::Repeat: + case react::ImageResizeMode::Repeat: return RCTResizeModeRepeat; } } @@ -726,8 +726,8 @@ static RCTResizeMode resizeModeFromCppEquiv(rct::ImageResizeMode resizeMode) */ + (RCTImageSource *)imageSourceFromImageView:(RCTImageComponentView *)view { - auto const imageProps = *std::static_pointer_cast(view.props); - rct::ImageSource cppImageSource = imageProps.sources.at(0); + auto const imageProps = *std::static_pointer_cast(view.props); + react::ImageSource cppImageSource = imageProps.sources.at(0); auto imageSize = CGSize{cppImageSource.size.width, cppImageSource.size.height}; NSURLRequest *request = [NSURLRequest requestWithURL:[NSURL URLWithString:RCTNSStringFromStringNilIfEmpty(cppImageSource.uri)]]; @@ -745,9 +745,9 @@ - (void)prepareForRecycle _initialPropsSet = NO; } -+ (rct::ComponentDescriptorProvider)componentDescriptorProvider ++ (react::ComponentDescriptorProvider)componentDescriptorProvider { - return rct::concreteComponentDescriptorProvider(); + return react::concreteComponentDescriptorProvider(); } - (NSNumber *)getFontSizePropValue:(int)value @@ -757,20 +757,20 @@ - (NSNumber *)getFontSizePropValue:(int)value return nil; } -- (UISemanticContentAttribute)getDirectionPropValue:(rct::RNSScreenStackHeaderConfigDirection)direction +- (UISemanticContentAttribute)getDirectionPropValue:(react::RNSScreenStackHeaderConfigDirection)direction { switch (direction) { - case rct::RNSScreenStackHeaderConfigDirection::Rtl: + case react::RNSScreenStackHeaderConfigDirection::Rtl: return UISemanticContentAttributeForceRightToLeft; - case rct::RNSScreenStackHeaderConfigDirection::Ltr: + case react::RNSScreenStackHeaderConfigDirection::Ltr: return UISemanticContentAttributeForceLeftToRight; } } -- (void)updateProps:(rct::Props::Shared const &)props oldProps:(rct::Props::Shared const &)oldProps +- (void)updateProps:(react::Props::Shared const &)props oldProps:(react::Props::Shared const &)oldProps { - const auto &oldScreenProps = *std::static_pointer_cast(_props); - const auto &newScreenProps = *std::static_pointer_cast(props); + const auto &oldScreenProps = *std::static_pointer_cast(_props); + const auto &newScreenProps = *std::static_pointer_cast(props); BOOL needsNavigationControllerLayout = !_initialPropsSet; @@ -832,7 +832,7 @@ - (void)updateProps:(rct::Props::Shared const &)props oldProps:(rct::Props::Shar } _initialPropsSet = YES; - _props = std::static_pointer_cast(props); + _props = std::static_pointer_cast(props); [super updateProps:props oldProps:oldProps]; } diff --git a/ios/RNSScreenStackHeaderSubview.mm b/ios/RNSScreenStackHeaderSubview.mm index c8b1c8f572..c23c7b301d 100644 --- a/ios/RNSScreenStackHeaderSubview.mm +++ b/ios/RNSScreenStackHeaderSubview.mm @@ -8,7 +8,11 @@ #import #import -#endif +#endif // RCT_NEW_ARCH_ENABLED + +#ifdef RCT_NEW_ARCH_ENABLED +namespace react = facebook::react; +#endif // RCT_NEW_ARCH_ENABLED @interface RCTBridge (Private) + (RCTBridge *)currentBridge; @@ -25,7 +29,7 @@ @implementation RNSScreenStackHeaderSubview - (instancetype)initWithFrame:(CGRect)frame { if (self = [super initWithFrame:frame]) { - static const auto defaultProps = std::make_shared(); + static const auto defaultProps = std::make_shared(); _props = defaultProps; } @@ -39,24 +43,21 @@ - (void)prepareForRecycle [super prepareForRecycle]; } -- (void)updateProps:(facebook::react::Props::Shared const &)props - oldProps:(facebook::react::Props::Shared const &)oldProps +- (void)updateProps:(react::Props::Shared const &)props oldProps:(react::Props::Shared const &)oldProps { - const auto &newHeaderSubviewProps = - *std::static_pointer_cast(props); + const auto &newHeaderSubviewProps = *std::static_pointer_cast(props); [self setType:[RNSConvert RNSScreenStackHeaderSubviewTypeFromCppEquivalent:newHeaderSubviewProps.type]]; [super updateProps:props oldProps:oldProps]; } -+ (facebook::react::ComponentDescriptorProvider)componentDescriptorProvider ++ (react::ComponentDescriptorProvider)componentDescriptorProvider { - return facebook::react::concreteComponentDescriptorProvider< - facebook::react::RNSScreenStackHeaderSubviewComponentDescriptor>(); + return react::concreteComponentDescriptorProvider(); } -- (void)updateLayoutMetrics:(const facebook::react::LayoutMetrics &)layoutMetrics - oldLayoutMetrics:(const facebook::react::LayoutMetrics &)oldLayoutMetrics +- (void)updateLayoutMetrics:(const react::LayoutMetrics &)layoutMetrics + oldLayoutMetrics:(const react::LayoutMetrics &)oldLayoutMetrics { CGRect frame = RCTCGRectFromRect(layoutMetrics.frame); // CALayer will crash if we pass NaN or Inf values. diff --git a/ios/RNSSearchBar.mm b/ios/RNSSearchBar.mm index 1052758161..39e06c9ad1 100644 --- a/ios/RNSSearchBar.mm +++ b/ios/RNSSearchBar.mm @@ -13,7 +13,11 @@ #import #import #import "RNSConvert.h" -#endif +#endif // RCT_NEW_ARCH_ENABLED + +#ifdef RCT_NEW_ARCH_ENABLED +namespace react = facebook::react; +#endif // RCT_NEW_ARCH_ENABLED @implementation RNSSearchBar { __weak RCTBridge *_bridge; @@ -36,7 +40,7 @@ - (instancetype)initWithBridge:(RCTBridge *)bridge - (instancetype)init { if (self = [super init]) { - static const auto defaultProps = std::make_shared(); + static const auto defaultProps = std::make_shared(); _props = defaultProps; [self initCommonProps]; } @@ -56,8 +60,8 @@ - (void)emitOnFocusEvent { #ifdef RCT_NEW_ARCH_ENABLED if (_eventEmitter != nullptr) { - std::dynamic_pointer_cast(_eventEmitter) - ->onFocus(facebook::react::RNSSearchBarEventEmitter::OnFocus{}); + std::dynamic_pointer_cast(_eventEmitter) + ->onFocus(react::RNSSearchBarEventEmitter::OnFocus{}); } #else if (self.onFocus) { @@ -70,8 +74,8 @@ - (void)emitOnBlurEvent { #ifdef RCT_NEW_ARCH_ENABLED if (_eventEmitter != nullptr) { - std::dynamic_pointer_cast(_eventEmitter) - ->onBlur(facebook::react::RNSSearchBarEventEmitter::OnBlur{}); + std::dynamic_pointer_cast(_eventEmitter) + ->onBlur(react::RNSSearchBarEventEmitter::OnBlur{}); } #else if (self.onBlur) { @@ -84,9 +88,9 @@ - (void)emitOnSearchButtonPressEventWithText:(NSString *)text { #ifdef RCT_NEW_ARCH_ENABLED if (_eventEmitter != nullptr) { - std::dynamic_pointer_cast(_eventEmitter) + std::dynamic_pointer_cast(_eventEmitter) ->onSearchButtonPress( - facebook::react::RNSSearchBarEventEmitter::OnSearchButtonPress{.text = RCTStringFromNSString(text)}); + react::RNSSearchBarEventEmitter::OnSearchButtonPress{.text = RCTStringFromNSString(text)}); } #else if (self.onSearchButtonPress) { @@ -101,8 +105,8 @@ - (void)emitOnCancelButtonPressEvent { #ifdef RCT_NEW_ARCH_ENABLED if (_eventEmitter != nullptr) { - std::dynamic_pointer_cast(_eventEmitter) - ->onCancelButtonPress(facebook::react::RNSSearchBarEventEmitter::OnCancelButtonPress{}); + std::dynamic_pointer_cast(_eventEmitter) + ->onCancelButtonPress(react::RNSSearchBarEventEmitter::OnCancelButtonPress{}); } #else if (self.onCancelButtonPress) { @@ -115,8 +119,8 @@ - (void)emitOnChangeTextEventWithText:(NSString *)text { #ifdef RCT_NEW_ARCH_ENABLED if (_eventEmitter != nullptr) { - std::dynamic_pointer_cast(_eventEmitter) - ->onChangeText(facebook::react::RNSSearchBarEventEmitter::OnChangeText{.text = RCTStringFromNSString(text)}); + std::dynamic_pointer_cast(_eventEmitter) + ->onChangeText(react::RNSSearchBarEventEmitter::OnChangeText{.text = RCTStringFromNSString(text)}); } #else if (self.onChangeText) { @@ -299,11 +303,10 @@ - (void)setText:(NSString *)text #pragma mark-- Fabric specific #ifdef RCT_NEW_ARCH_ENABLED -- (void)updateProps:(facebook::react::Props::Shared const &)props - oldProps:(facebook::react::Props::Shared const &)oldProps +- (void)updateProps:(react::Props::Shared const &)props oldProps:(react::Props::Shared const &)oldProps { - const auto &oldScreenProps = *std::static_pointer_cast(_props); - const auto &newScreenProps = *std::static_pointer_cast(props); + const auto &oldScreenProps = *std::static_pointer_cast(_props); + const auto &newScreenProps = *std::static_pointer_cast(props); [self setHideWhenScrolling:newScreenProps.hideWhenScrolling]; @@ -346,9 +349,9 @@ - (void)updateProps:(facebook::react::Props::Shared const &)props [super updateProps:props oldProps:oldProps]; } -+ (facebook::react::ComponentDescriptorProvider)componentDescriptorProvider ++ (react::ComponentDescriptorProvider)componentDescriptorProvider { - return facebook::react::concreteComponentDescriptorProvider(); + return react::concreteComponentDescriptorProvider(); } - (void)handleCommand:(const NSString *)commandName args:(const NSArray *)args