From e877f79d615d8887f767f62eaa84fc7474b79cc7 Mon Sep 17 00:00:00 2001 From: Maciej Stosio Date: Mon, 3 Jun 2024 17:50:07 +0200 Subject: [PATCH 01/15] feat: add gradle task to automatically copy the codegen artifacts --- FabricExample/android/gradle.properties | 2 + FabricTestExample/android/gradle.properties | 2 + android/build.gradle | 58 +++++++++++++++++++++ android/gradle.properties | 3 ++ 4 files changed, 65 insertions(+) diff --git a/FabricExample/android/gradle.properties b/FabricExample/android/gradle.properties index 99fc223edf..be4b1f207c 100644 --- a/FabricExample/android/gradle.properties +++ b/FabricExample/android/gradle.properties @@ -39,3 +39,5 @@ newArchEnabled=true # Use this property to enable or disable the Hermes JS engine. # If set to false, you will be using JSC instead. hermesEnabled=true + +isScreensExampleApp=true diff --git a/FabricTestExample/android/gradle.properties b/FabricTestExample/android/gradle.properties index 67b6139770..e1104c5ddd 100644 --- a/FabricTestExample/android/gradle.properties +++ b/FabricTestExample/android/gradle.properties @@ -41,3 +41,5 @@ newArchEnabled=true hermesEnabled=true disableMultipleInstancesCheck=true + +isScreensExampleApp=true diff --git a/android/build.gradle b/android/build.gradle index b751186b1b..0acb7ff668 100644 --- a/android/build.gradle +++ b/android/build.gradle @@ -192,3 +192,61 @@ dependencies { } } } + +def isScreensExampleApp() { + return project.hasProperty('isScreensExampleApp') && project.property('isScreensExampleApp') +} + +task copyCodegenArtifacts(type: Copy) { + group 'After build tasks' + description 'Tasks which copy codegen artifacts to paper architecture' + + if (!isScreensExampleApp()) { + return + } + + dependsOn tasks.generateCodegenArtifactsFromSchema + + def absoluteCodegenArtifactsPaperDestination = "${project.rootDir}/../../${project.property('codegenArtifactsPaperDestination')}" + def absoluteCodegenArtifactsSource = "${project.rootDir}/../../${project.property('codegenArtifactsSource')}" + + println absoluteCodegenArtifactsPaperDestination + println absoluteCodegenArtifactsSource + + def existingFiles = fileTree(absoluteCodegenArtifactsPaperDestination).matching { + include '**/*.java' + } + + def generatedFiles = fileTree(absoluteCodegenArtifactsSource).matching { + include '**/*.java' + } + + def existingFilesMap = [:] + + existingFiles.forEach { existingFile -> + existingFilesMap[existingFile.name] = 1 + } + + generatedFiles.forEach { generatedFile -> + if (!existingFilesMap.containsKey(generatedFile.name)) { + println generatedFile.name + " not found in paper dir" + } + } + + if (existingFiles.size() <= 0) { + throw new Exception('Paper destination with codegen interfaces is empty.') + } + + if (existingFiles.size() > generatedFiles.size()) { + throw new Exception('Number od generated artifacts should be greather then or equal to paper interfaces.') + } + + + from absoluteCodegenArtifactsSource + include existingFiles.collect { it.name } + into absoluteCodegenArtifactsPaperDestination +} + +if (isScreensExampleApp()) { + tasks.generateCodegenArtifactsFromSchema.finalizedBy('copyCodegenArtifacts') +} \ No newline at end of file diff --git a/android/gradle.properties b/android/gradle.properties index 708d4222b3..aa9d7749ca 100644 --- a/android/gradle.properties +++ b/android/gradle.properties @@ -21,3 +21,6 @@ android.useAndroidX=true android.enableJetifier=true kotlin.code.style=official + +codegenArtifactsSource=android/build/generated/source/codegen/java/com/facebook/react/viewmanagers +codegenArtifactsPaperDestination=android/src/paper/java/com/facebook/react/viewmanagers/ \ No newline at end of file From d7d9ccd85b538d9d58c9f3e5e1725871cafcabed Mon Sep 17 00:00:00 2001 From: Maciej Stosio Date: Mon, 3 Jun 2024 17:56:24 +0200 Subject: [PATCH 02/15] chore: remove unnecessary logs --- android/build.gradle | 3 --- 1 file changed, 3 deletions(-) diff --git a/android/build.gradle b/android/build.gradle index 0acb7ff668..1d89363b8c 100644 --- a/android/build.gradle +++ b/android/build.gradle @@ -210,9 +210,6 @@ task copyCodegenArtifacts(type: Copy) { def absoluteCodegenArtifactsPaperDestination = "${project.rootDir}/../../${project.property('codegenArtifactsPaperDestination')}" def absoluteCodegenArtifactsSource = "${project.rootDir}/../../${project.property('codegenArtifactsSource')}" - println absoluteCodegenArtifactsPaperDestination - println absoluteCodegenArtifactsSource - def existingFiles = fileTree(absoluteCodegenArtifactsPaperDestination).matching { include '**/*.java' } From 3242ab1d0e5810494246e6a4a96d4fe58504594a Mon Sep 17 00:00:00 2001 From: Maciej Stosio Date: Tue, 4 Jun 2024 08:42:51 +0200 Subject: [PATCH 03/15] fix: move the logic to execution phase --- android/build.gradle | 56 ++++++++++++++++++++++++-------------------- 1 file changed, 30 insertions(+), 26 deletions(-) diff --git a/android/build.gradle b/android/build.gradle index 1d89363b8c..e09fee7e2f 100644 --- a/android/build.gradle +++ b/android/build.gradle @@ -197,7 +197,7 @@ def isScreensExampleApp() { return project.hasProperty('isScreensExampleApp') && project.property('isScreensExampleApp') } -task copyCodegenArtifacts(type: Copy) { +tasks.register("copyCodegenArtifacts") { group 'After build tasks' description 'Tasks which copy codegen artifacts to paper architecture' @@ -207,41 +207,45 @@ task copyCodegenArtifacts(type: Copy) { dependsOn tasks.generateCodegenArtifactsFromSchema - def absoluteCodegenArtifactsPaperDestination = "${project.rootDir}/../../${project.property('codegenArtifactsPaperDestination')}" - def absoluteCodegenArtifactsSource = "${project.rootDir}/../../${project.property('codegenArtifactsSource')}" + doLast { - def existingFiles = fileTree(absoluteCodegenArtifactsPaperDestination).matching { - include '**/*.java' - } + def absoluteCodegenArtifactsPaperDestination = "${project.rootDir}/../../${project.property('codegenArtifactsPaperDestination')}" + def absoluteCodegenArtifactsSource = "${project.rootDir}/../../${project.property('codegenArtifactsSource')}" - def generatedFiles = fileTree(absoluteCodegenArtifactsSource).matching { - include '**/*.java' - } + def existingFiles = fileTree(absoluteCodegenArtifactsPaperDestination).matching { + include '**/*.java' + } - def existingFilesMap = [:] + def generatedFiles = fileTree(absoluteCodegenArtifactsSource).matching { + include '**/*.java' + } - existingFiles.forEach { existingFile -> - existingFilesMap[existingFile.name] = 1 - } + def existingFilesMap = [:] - generatedFiles.forEach { generatedFile -> - if (!existingFilesMap.containsKey(generatedFile.name)) { - println generatedFile.name + " not found in paper dir" + existingFiles.forEach { existingFile -> + existingFilesMap[existingFile.name] = 1 } - } - if (existingFiles.size() <= 0) { - throw new Exception('Paper destination with codegen interfaces is empty.') - } + generatedFiles.forEach { generatedFile -> + if (!existingFilesMap.containsKey(generatedFile.name)) { + println generatedFile.name + " not found in paper dir" + } + } - if (existingFiles.size() > generatedFiles.size()) { - throw new Exception('Number od generated artifacts should be greather then or equal to paper interfaces.') - } + if (existingFiles.size() <= 0) { + throw new Exception('Paper destination with codegen interfaces is empty.') + } + if (existingFiles.size() > generatedFiles.size()) { + throw new Exception('Number od generated artifacts should be greather then or equal to paper interfaces.') + } - from absoluteCodegenArtifactsSource - include existingFiles.collect { it.name } - into absoluteCodegenArtifactsPaperDestination + copy { + from absoluteCodegenArtifactsSource + include existingFiles.collect { it.name } + into absoluteCodegenArtifactsPaperDestination + } + } } if (isScreensExampleApp()) { From bd65c0c7bb6d6a12facbf79e40c1a04b89aebb4f Mon Sep 17 00:00:00 2001 From: Maciej Stosio Date: Tue, 4 Jun 2024 10:32:06 +0200 Subject: [PATCH 04/15] chore: add changes from comments --- Example/android/gradle.properties | 2 ++ TVOSExample/android/gradle.properties | 2 ++ TestsExample/android/gradle.properties | 2 ++ android/build.gradle | 33 +++++++++++++++++++------- 4 files changed, 31 insertions(+), 8 deletions(-) diff --git a/Example/android/gradle.properties b/Example/android/gradle.properties index 4896485f57..c42be4f902 100644 --- a/Example/android/gradle.properties +++ b/Example/android/gradle.properties @@ -49,3 +49,5 @@ hermesEnabled=true # This is necessary, because the code checking for multiple instances # detects package versions from other example applications in the repository. disableMultipleInstancesCheck=true + +isScreensExampleApp=true \ No newline at end of file diff --git a/TVOSExample/android/gradle.properties b/TVOSExample/android/gradle.properties index d21d03f2b4..078d200ea3 100644 --- a/TVOSExample/android/gradle.properties +++ b/TVOSExample/android/gradle.properties @@ -26,3 +26,5 @@ android.enableJetifier=true # Version of flipper SDK to use with React Native FLIPPER_VERSION=0.75.1 + +isScreensExampleApp=true \ No newline at end of file diff --git a/TestsExample/android/gradle.properties b/TestsExample/android/gradle.properties index bb048c5716..beb6e20f02 100644 --- a/TestsExample/android/gradle.properties +++ b/TestsExample/android/gradle.properties @@ -41,3 +41,5 @@ newArchEnabled=false hermesEnabled=true disableMultipleInstancesCheck=true + +isScreensExampleApp=true \ No newline at end of file diff --git a/android/build.gradle b/android/build.gradle index e09fee7e2f..5317e30e6c 100644 --- a/android/build.gradle +++ b/android/build.gradle @@ -197,11 +197,28 @@ def isScreensExampleApp() { return project.hasProperty('isScreensExampleApp') && project.property('isScreensExampleApp') } +def getAbsoluteCodegenArtifactsPaperDestination() { + if (!project.hasProperty('codegenArtifactsPaperDestination')) { + throw new Exception('[RNScreens] Please fill codegenArtifactsPaperDestination variable in android/gradle.properties correct path to paper paper destination') + } + + return "${project.rootDir}/../../${project.property('codegenArtifactsPaperDestination')}" +} + +def getAbsoluteCodegenArtifactsSource() { + if (!project.hasProperty('codegenArtifactsSource')) { + throw new Exception('[RNScreens] Please fill codegenArtifactsSource variable in android/gradle.properties correct path to codegenerated artifacts') + } + + return "${project.rootDir}/../../${project.property('codegenArtifactsSource')}" +} + + tasks.register("copyCodegenArtifacts") { group 'After build tasks' description 'Tasks which copy codegen artifacts to paper architecture' - if (!isScreensExampleApp()) { + if (!isScreensExampleApp() || !isNewArchitectureEnabled()) { return } @@ -209,8 +226,8 @@ tasks.register("copyCodegenArtifacts") { doLast { - def absoluteCodegenArtifactsPaperDestination = "${project.rootDir}/../../${project.property('codegenArtifactsPaperDestination')}" - def absoluteCodegenArtifactsSource = "${project.rootDir}/../../${project.property('codegenArtifactsSource')}" + def absoluteCodegenArtifactsPaperDestination = getAbsoluteCodegenArtifactsPaperDestination() + def absoluteCodegenArtifactsSource = getAbsoluteCodegenArtifactsSource() def existingFiles = fileTree(absoluteCodegenArtifactsPaperDestination).matching { include '**/*.java' @@ -228,16 +245,16 @@ tasks.register("copyCodegenArtifacts") { generatedFiles.forEach { generatedFile -> if (!existingFilesMap.containsKey(generatedFile.name)) { - println generatedFile.name + " not found in paper dir" + println("[RNScreens] ${generatedFile.name} not found in paper dir, if it's used in Android you need to copy it manually and implement yourself before using auto-copy feature") } } - if (existingFiles.size() <= 0) { - throw new Exception('Paper destination with codegen interfaces is empty.') + if (existingFiles.size() == 0) { + throw new Exception("[RNScreens] Paper destination with codegen interfaces is empty. This might be okay if you don't have any interfaces/delegates used in Android, if that's not the case please check if codegenArtifactsPaperDestination in android/gradle.properties is correct") } if (existingFiles.size() > generatedFiles.size()) { - throw new Exception('Number od generated artifacts should be greather then or equal to paper interfaces.') + throw new Exception("[RNScreens] Number od generated artifacts should be greather then or equal to paper interfaces. Please check if codegenArtifactsSource in android/gradle.properties is correct") } copy { @@ -248,6 +265,6 @@ tasks.register("copyCodegenArtifacts") { } } -if (isScreensExampleApp()) { +if (isScreensExampleApp() && isNewArchitectureEnabled()) { tasks.generateCodegenArtifactsFromSchema.finalizedBy('copyCodegenArtifacts') } \ No newline at end of file From 340de960ef878893869aa6f4c33bb9a0fdf730ac Mon Sep 17 00:00:00 2001 From: Maciej Stosio Date: Tue, 4 Jun 2024 10:39:05 +0200 Subject: [PATCH 05/15] chore: add comment to gradle properties --- android/gradle.properties | 3 +++ 1 file changed, 3 insertions(+) diff --git a/android/gradle.properties b/android/gradle.properties index aa9d7749ca..1c581571ff 100644 --- a/android/gradle.properties +++ b/android/gradle.properties @@ -22,5 +22,8 @@ android.enableJetifier=true kotlin.code.style=official +# Path to codegen artifacts, used for task (copyCodegenArtifacts) that automates copying them to paper destination codegenArtifactsSource=android/build/generated/source/codegen/java/com/facebook/react/viewmanagers +# Destination to peper path where codegen interfaces should stored and then implemented, so we have consistency in both architectures. +# Used for task (copyCodegenArtifacts) that automates copying those interfaces/delegates when codegen is run codegenArtifactsPaperDestination=android/src/paper/java/com/facebook/react/viewmanagers/ \ No newline at end of file From 06fb181700d00b21aab04a995504cb65dd6264d0 Mon Sep 17 00:00:00 2001 From: Maciej Stosio Date: Tue, 4 Jun 2024 14:27:49 +0200 Subject: [PATCH 06/15] Update TVOSExample/android/gradle.properties Co-authored-by: Kacper Kafara --- TVOSExample/android/gradle.properties | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/TVOSExample/android/gradle.properties b/TVOSExample/android/gradle.properties index 078d200ea3..2b0e2126ce 100644 --- a/TVOSExample/android/gradle.properties +++ b/TVOSExample/android/gradle.properties @@ -27,4 +27,4 @@ android.enableJetifier=true # Version of flipper SDK to use with React Native FLIPPER_VERSION=0.75.1 -isScreensExampleApp=true \ No newline at end of file +isScreensExampleApp=true From c6a972b6d419ceb766ec2536f126836519cf75ea Mon Sep 17 00:00:00 2001 From: Maciej Stosio Date: Tue, 4 Jun 2024 14:27:56 +0200 Subject: [PATCH 07/15] Update android/gradle.properties Co-authored-by: Kacper Kafara --- android/gradle.properties | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/android/gradle.properties b/android/gradle.properties index 1c581571ff..978fbe3c54 100644 --- a/android/gradle.properties +++ b/android/gradle.properties @@ -26,4 +26,4 @@ kotlin.code.style=official codegenArtifactsSource=android/build/generated/source/codegen/java/com/facebook/react/viewmanagers # Destination to peper path where codegen interfaces should stored and then implemented, so we have consistency in both architectures. # Used for task (copyCodegenArtifacts) that automates copying those interfaces/delegates when codegen is run -codegenArtifactsPaperDestination=android/src/paper/java/com/facebook/react/viewmanagers/ \ No newline at end of file +codegenArtifactsPaperDestination=android/src/paper/java/com/facebook/react/viewmanagers/ From 6eeda1147d11e30b882f568ec948bef5150b728d Mon Sep 17 00:00:00 2001 From: Maciej Stosio Date: Tue, 4 Jun 2024 14:28:03 +0200 Subject: [PATCH 08/15] Update TestsExample/android/gradle.properties Co-authored-by: Kacper Kafara --- TestsExample/android/gradle.properties | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/TestsExample/android/gradle.properties b/TestsExample/android/gradle.properties index beb6e20f02..36f80eca00 100644 --- a/TestsExample/android/gradle.properties +++ b/TestsExample/android/gradle.properties @@ -42,4 +42,4 @@ hermesEnabled=true disableMultipleInstancesCheck=true -isScreensExampleApp=true \ No newline at end of file +isScreensExampleApp=true From 9233007211afcb497bb3cec548c88ef20a4f53fd Mon Sep 17 00:00:00 2001 From: Maciej Stosio Date: Tue, 4 Jun 2024 14:29:01 +0200 Subject: [PATCH 09/15] Update Example/android/gradle.properties Co-authored-by: Kacper Kafara --- Example/android/gradle.properties | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Example/android/gradle.properties b/Example/android/gradle.properties index c42be4f902..729cdc9f66 100644 --- a/Example/android/gradle.properties +++ b/Example/android/gradle.properties @@ -50,4 +50,4 @@ hermesEnabled=true # detects package versions from other example applications in the repository. disableMultipleInstancesCheck=true -isScreensExampleApp=true \ No newline at end of file +isScreensExampleApp=true From 5bf21e2c40af3df89797bd8ba77bfc9adb2d956c Mon Sep 17 00:00:00 2001 From: Maciej Stosio Date: Tue, 4 Jun 2024 14:29:07 +0200 Subject: [PATCH 10/15] Update android/build.gradle Co-authored-by: Kacper Kafara --- android/build.gradle | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/android/build.gradle b/android/build.gradle index 5317e30e6c..b082d1e3ac 100644 --- a/android/build.gradle +++ b/android/build.gradle @@ -267,4 +267,4 @@ tasks.register("copyCodegenArtifacts") { if (isScreensExampleApp() && isNewArchitectureEnabled()) { tasks.generateCodegenArtifactsFromSchema.finalizedBy('copyCodegenArtifacts') -} \ No newline at end of file +} From 9a2a66e36f40345e800cb005bd69ce1827054051 Mon Sep 17 00:00:00 2001 From: Maciej Stosio Date: Tue, 4 Jun 2024 14:31:50 +0200 Subject: [PATCH 11/15] chore: changes from comments --- android/build.gradle | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/android/build.gradle b/android/build.gradle index 5317e30e6c..00df73fc12 100644 --- a/android/build.gradle +++ b/android/build.gradle @@ -194,7 +194,7 @@ dependencies { } def isScreensExampleApp() { - return project.hasProperty('isScreensExampleApp') && project.property('isScreensExampleApp') + return project.hasProperty('isScreensExampleApp') && project.property('isScreensExampleApp') == "true" } def getAbsoluteCodegenArtifactsPaperDestination() { @@ -250,7 +250,7 @@ tasks.register("copyCodegenArtifacts") { } if (existingFiles.size() == 0) { - throw new Exception("[RNScreens] Paper destination with codegen interfaces is empty. This might be okay if you don't have any interfaces/delegates used in Android, if that's not the case please check if codegenArtifactsPaperDestination in android/gradle.properties is correct") + println "[RNScreens] Paper destination with codegen interfaces is empty. This might be okay if you don't have any interfaces/delegates used in Android, if that's not the case please check if codegenArtifactsPaperDestination in android/gradle.properties is correct" } if (existingFiles.size() > generatedFiles.size()) { From 5afd502c2b94a6035ac128860340695feaffc4e6 Mon Sep 17 00:00:00 2001 From: Maciej Stosio Date: Tue, 4 Jun 2024 15:18:57 +0200 Subject: [PATCH 12/15] fix: change println for logger.warn --- android/build.gradle | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/android/build.gradle b/android/build.gradle index c467d3c5b5..89ea486f6d 100644 --- a/android/build.gradle +++ b/android/build.gradle @@ -245,12 +245,12 @@ tasks.register("copyCodegenArtifacts") { generatedFiles.forEach { generatedFile -> if (!existingFilesMap.containsKey(generatedFile.name)) { - println("[RNScreens] ${generatedFile.name} not found in paper dir, if it's used in Android you need to copy it manually and implement yourself before using auto-copy feature") + logger.warn("[RNScreens] ${generatedFile.name} not found in paper dir, if it's used in Android you need to copy it manually and implement yourself before using auto-copy feature") } } if (existingFiles.size() == 0) { - println "[RNScreens] Paper destination with codegen interfaces is empty. This might be okay if you don't have any interfaces/delegates used in Android, if that's not the case please check if codegenArtifactsPaperDestination in android/gradle.properties is correct" + logger.warn("[RNScreens] Paper destination with codegen interfaces is empty. This might be okay if you don't have any interfaces/delegates used in Android, if that's not the case please check if codegenArtifactsPaperDestination in android/gradle.properties is correct") } if (existingFiles.size() > generatedFiles.size()) { From a0eb85ccf56b1ecbfae224651cc229d1a49871ae Mon Sep 17 00:00:00 2001 From: Maciej Stosio Date: Tue, 4 Jun 2024 15:29:52 +0200 Subject: [PATCH 13/15] Update android/gradle.properties Co-authored-by: Kacper Kafara --- android/gradle.properties | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/android/gradle.properties b/android/gradle.properties index 978fbe3c54..129e1a6947 100644 --- a/android/gradle.properties +++ b/android/gradle.properties @@ -22,7 +22,7 @@ android.enableJetifier=true kotlin.code.style=official -# Path to codegen artifacts, used for task (copyCodegenArtifacts) that automates copying them to paper destination +# Path to codegen output directory with this library view manager's interfaces & delegates. Used by `copyCodegenArtifacts` task that helps to synchronise newly generated files with their Paper conterparts. codegenArtifactsSource=android/build/generated/source/codegen/java/com/facebook/react/viewmanagers # Destination to peper path where codegen interfaces should stored and then implemented, so we have consistency in both architectures. # Used for task (copyCodegenArtifacts) that automates copying those interfaces/delegates when codegen is run From aa0de55be104548b13896dbda53865a563b42b0b Mon Sep 17 00:00:00 2001 From: Maciej Stosio Date: Tue, 4 Jun 2024 15:30:16 +0200 Subject: [PATCH 14/15] Update android/gradle.properties Co-authored-by: Kacper Kafara --- android/gradle.properties | 1 + 1 file changed, 1 insertion(+) diff --git a/android/gradle.properties b/android/gradle.properties index 129e1a6947..f30281616f 100644 --- a/android/gradle.properties +++ b/android/gradle.properties @@ -24,6 +24,7 @@ kotlin.code.style=official # Path to codegen output directory with this library view manager's interfaces & delegates. Used by `copyCodegenArtifacts` task that helps to synchronise newly generated files with their Paper conterparts. codegenArtifactsSource=android/build/generated/source/codegen/java/com/facebook/react/viewmanagers + # Destination to peper path where codegen interfaces should stored and then implemented, so we have consistency in both architectures. # Used for task (copyCodegenArtifacts) that automates copying those interfaces/delegates when codegen is run codegenArtifactsPaperDestination=android/src/paper/java/com/facebook/react/viewmanagers/ From 2e797e12cb66e7fbf872ae56dbdaa9b5f2ade7b0 Mon Sep 17 00:00:00 2001 From: Maciej Stosio Date: Tue, 4 Jun 2024 15:30:32 +0200 Subject: [PATCH 15/15] Update android/gradle.properties Co-authored-by: Kacper Kafara --- android/gradle.properties | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/android/gradle.properties b/android/gradle.properties index f30281616f..c2b7b4bedf 100644 --- a/android/gradle.properties +++ b/android/gradle.properties @@ -25,6 +25,6 @@ kotlin.code.style=official # Path to codegen output directory with this library view manager's interfaces & delegates. Used by `copyCodegenArtifacts` task that helps to synchronise newly generated files with their Paper conterparts. codegenArtifactsSource=android/build/generated/source/codegen/java/com/facebook/react/viewmanagers -# Destination to peper path where codegen interfaces should stored and then implemented, so we have consistency in both architectures. +# Path to directory with view manager's interfaces & delegates used while running on Paper architecture. This property is used as output path for `copyCodegenArtifacts` task. # Used for task (copyCodegenArtifacts) that automates copying those interfaces/delegates when codegen is run codegenArtifactsPaperDestination=android/src/paper/java/com/facebook/react/viewmanagers/