From 28e884d5751a0e300a6d4eecb8797b38ec440517 Mon Sep 17 00:00:00 2001 From: Kacper Kafara Date: Sat, 8 Jun 2024 14:21:17 +0200 Subject: [PATCH 1/2] Fix lint warning --- android/src/main/java/com/swmansion/rnscreens/CustomToolbar.kt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/android/src/main/java/com/swmansion/rnscreens/CustomToolbar.kt b/android/src/main/java/com/swmansion/rnscreens/CustomToolbar.kt index 3bc36355aa..cd521057af 100644 --- a/android/src/main/java/com/swmansion/rnscreens/CustomToolbar.kt +++ b/android/src/main/java/com/swmansion/rnscreens/CustomToolbar.kt @@ -1,7 +1,9 @@ package com.swmansion.rnscreens +import android.annotation.SuppressLint import android.content.Context import androidx.appcompat.widget.Toolbar // This class is used to store config closer to search bar +@SuppressLint("ViewConstructor") open class CustomToolbar(context: Context, val config: ScreenStackHeaderConfig) : Toolbar(context) From 2fe1e99fa78392507dc48aa971f560bde7b1b26a Mon Sep 17 00:00:00 2001 From: Kacper Kafara Date: Mon, 17 Jun 2024 15:24:04 +0200 Subject: [PATCH 2/2] Suppress lints in more views --- .../src/main/java/com/swmansion/rnscreens/CustomSearchView.kt | 2 ++ android/src/main/java/com/swmansion/rnscreens/CustomToolbar.kt | 2 +- android/src/main/java/com/swmansion/rnscreens/Screen.kt | 2 +- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/android/src/main/java/com/swmansion/rnscreens/CustomSearchView.kt b/android/src/main/java/com/swmansion/rnscreens/CustomSearchView.kt index 28bd4ae973..89f7c7c7bb 100644 --- a/android/src/main/java/com/swmansion/rnscreens/CustomSearchView.kt +++ b/android/src/main/java/com/swmansion/rnscreens/CustomSearchView.kt @@ -1,10 +1,12 @@ package com.swmansion.rnscreens +import android.annotation.SuppressLint import android.content.Context import androidx.activity.OnBackPressedCallback import androidx.appcompat.widget.SearchView import androidx.fragment.app.Fragment +@SuppressLint("ViewConstructor") // Only we construct this view, it is never inflated. class CustomSearchView(context: Context, fragment: Fragment) : SearchView(context) { /* CustomSearchView uses some variables from SearchView. They are listed below with links to documentation diff --git a/android/src/main/java/com/swmansion/rnscreens/CustomToolbar.kt b/android/src/main/java/com/swmansion/rnscreens/CustomToolbar.kt index cd521057af..c774078399 100644 --- a/android/src/main/java/com/swmansion/rnscreens/CustomToolbar.kt +++ b/android/src/main/java/com/swmansion/rnscreens/CustomToolbar.kt @@ -5,5 +5,5 @@ import android.content.Context import androidx.appcompat.widget.Toolbar // This class is used to store config closer to search bar -@SuppressLint("ViewConstructor") +@SuppressLint("ViewConstructor") // Only we construct this view, it is never inflated. open class CustomToolbar(context: Context, val config: ScreenStackHeaderConfig) : Toolbar(context) diff --git a/android/src/main/java/com/swmansion/rnscreens/Screen.kt b/android/src/main/java/com/swmansion/rnscreens/Screen.kt index 1856eed100..4eacaf0e4c 100644 --- a/android/src/main/java/com/swmansion/rnscreens/Screen.kt +++ b/android/src/main/java/com/swmansion/rnscreens/Screen.kt @@ -18,7 +18,7 @@ import com.facebook.react.uimanager.UIManagerHelper import com.facebook.react.uimanager.UIManagerModule import com.swmansion.rnscreens.events.HeaderHeightChangeEvent -@SuppressLint("ViewConstructor") +@SuppressLint("ViewConstructor") // Only we construct this view, it is never inflated. class Screen(context: ReactContext?) : FabricEnabledViewGroup(context) { val fragment: Fragment? get() = fragmentWrapper?.fragment